Re: libv8-3.14: Add support for hurd-i386 (for review)

[Samuel Thibault <sthibault@debian.org>]

Hello,

Svante Signell, le Thu 01 May 2014 22:26:12 +0200, a écrit :
> - rules.patch: Add support for hurd-i386 in architecture list
> - 0015_v8.patch: tools/gyp/v8.gyp: add platform-gnu.cc
> - 0016_gnu.patch: src/platform-gnu.cc: new file with platform specific code

It seeems fine, except

> +// 0 is never a valid thread id on GNU/Hurd since tids and pids share a
> +// name space and pid 0 is used to kill the group (see man 2 kill).

This comment does not apply to GNU/Hurd: tids and pids do not share name
space.  It happens that our implementation indeed reserves (pthread)0 as
an invalid value, so this is indeed correct:

> +static const pthread_t kNoThread = (pthread_t) 0;


> +double ceiling(double x) {
> +    // Correct as on OS X
> +    if (-1.0 < x && x < 0.0) {
> +        return -0.0;
> +    } else {
> +        return ceil(x);
> +    }
> +}

We are using glibc like Linux, I don't think we need the correction.

Samuel