[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 1/4] Also check _POSIX_TIMERS > 0. Fix build on GNU/Hurd.



Rémi Denis-Courmont, le Wed 19 Feb 2014 14:17:01 +0100, a écrit :
> > From looking at the build error, it seems the actual error is that
> > vlc_clock_id is not defined, i.e. the actual issue comes from the
> > fact that the #if at the top of the file don't match the #if in the
> > source code.
> 
> VLC relies on the fact that clock selection support implies timers
> support. GNU/Hurd fails to provide that specified warranty. From my point
> of view as VLC developer, this is a GNU/Hurd bug.

Yes, that's also what I said.

But as I said, we can not fix it by just defining _CLOCK_TIMER, since we
do not have timer_create and friends yet.

> Besides, I'd note that clock selection makes no practical sense without
> timers (for clock_gettime() and CLOCK_REALTIME). The easy fix is to stop
> pretending that POSIX.2008 and POSIX clock selection are supported.

And then we will have other breaks in other software...

> A better but more involved fix would supply POSIX timers (that should
> be easy; monotonic clock is the "harder" part).

That's also what I said.

Samuel


Reply to: