[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/4] modules/audio_output/oss.c: ifdef some ioctls. Fix build on GNU/Hurd.



Gabriele Giacone, le Tue 18 Feb 2014 21:06:14 +0100, a écrit :
> +#ifndef __GNU__
>      if (ioctl (fd, SNDCTL_SYSINFO, &si) < 0)
>      {
>          msg_Err (aout, "cannot get system infos: %s", vlc_strerror(errno));
>          goto out;
>      }
> +#endif

That's obviously deemed to get horrible results at execution:

>      msg_Dbg (aout, "using %s version %s (0x%06X) under %s", si.product,
>               si.version, si.versionnum, si.license);

Just that part would print garbage, since si would not have been
initialized. Same for AUDIOINFO.

Samuel


Reply to: