Re: pristine-tar: FTBFS on hurd-i386 (for review)
On Tue, 2014-02-11 at 19:24 +0100, Samuel Thibault wrote:
> Svante Signell, le Tue 11 Feb 2014 18:52:28 +0100, a écrit :
> > Maybe I got it wrong then, perhaps const would be better.
>
> Const would mean you're preventing yourself from writing to it. But you
> *want* to write to it with snprintf. Why do you believe you need to add
> something else than char*?
Never mind for this case, (and I used static, to make it local for that
function?)
> > - char path_buf[PATH_MAX];
> > + char *path_buf = NULL;
>
> Why setting it to NULL?
To avoid compiler warnings?
> > - snprintf(path_buf, sizeof(path_buf), "%s/%s", PKGLIBDIR, zombie);
> > + len = strlen(PKGLIBDIR) + 1 + strlen(zombie) + 1;
>
> That seems to be missing a malloc here, doesn't it?
Ah, thanks!
A bug report with the updated patch will be submitted.
Reply to: