Re: heimdal: FTBFS on hurd-i386 (for review)

[Samuel Thibault <sthibault@debian.org>]

Svante Signell, le Tue 11 Feb 2014 17:48:50 +0100, a écrit :
>      uint64_t param1;
>      uint64_t syscall;
>  };
> +#ifdef __GNU__
> +/* FIXME: Enter the correct values here */
> +#define _IOT_sundevdata _IOT(_IOTS(long), 7, 0, 0, 0, 0)

Why long? The structure contains uint64_t, not longs. Did you read the
ioctl part of the porting guideline wiki page?

Also, the _ILP32 case needs to be handled, too.

> +#else
>  #define VIOC_SUN_SYSCALL_DEV _IOW('C', 1, struct sundevdata)
>  #endif
> +#endif /* __GNU__ */

Why not defining VIOC_SUN_SYSCALL_DEV in the GNU case? Also, take care
of the #ifdef/#endif parenthesing, GNU does not belong to where you have
put it.

Samuel