[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch for GNU/Hurd



On Tue, 2013-08-27 at 23:52 +0200, Samuel Thibault wrote:
> Svante Signell, le Tue 27 Aug 2013 23:39:20 +0200, a écrit :
> > During the compile there was a lot of complaints like:
> > tools/strutil.cpp:1:0: warning: -fprefetch-loop-arrays not supported for
> > this target (try -march switches) [enabled by default]
> > 
> > And the execution of zsnes results were the same.
> 
> Then no need to drop the option just for the sake of silenting a
> warning.  Warnings are there to tell us that something has to be fixed.
> Silenting them is the worst thing you could do.
> 
> FTR, this warning happens on linux-i386 too, so there is really no
> reason for special-casing hurd-i386.

Since the warning is present also for linux-i386 (and kfreebsd-i386),
the -fprefetch-loop-arrays flag should be removed. However, that is not
a porting issue so I've chosen not to touch this part. Updated patch
attached (the old one had a small bug). With the new patch the program
runs :) Tried under X with Windowmaker as window manager.

Remaining warnings below:
ManyMouse: -1 mice detected.
Failed to write cookie file: Unknown error (os/kern) 303
socket(): Protocol wrong type for socket
socket(): Protocol wrong type for socket
ZSNES could not find any joysticks.
--- a/src/configure.in
+++ b/src/configure.in
@@ -83,6 +83,9 @@
   *-*-cygwin* | *-*-*ming*)
     NFLAGS="$NFLAGS -f win32"
     ;;
+  *-*-gnu*)
+    NFLAGS="$NFLAGS -f elf -DELF"
+    ;;
   *)
     AC_MSG_ERROR(This target is not supported)
     ;;
--- a/src/gblhdr.h
+++ b/src/gblhdr.h
@@ -122,9 +122,13 @@
 #ifdef linux
 #include <asm/ioctls.h>
 #else
+#ifdef __GNU__
+#include <sys/ioctls.h>
+#else
 #include <sys/filio.h>
 #endif
 #endif
+#endif
 
 
 #endif

Reply to: