Re: libpst: FTBFS on hurd-i386 (for review)

[Svante Signell <svante.signell@telia.com>]

On Sun, 2012-08-26 at 15:18 +0200, Samuel Thibault wrote:
> Svante Signell, le Sun 26 Aug 2012 15:08:35 +0200, a écrit :
> > > > -    snprintf(pdf_name, sizeof(pdf_name), "dii%06d", ++email_sequence);
> > > > +    /* Note; allocating the largest string length to pdf_name */
> > > > +    int len = strlen(output_directory) + 4 + 6 + 4;
> > > 
> > > why 4 before 6 ?
> > 
> > See below.
> 
> A 3 + 6 + 4 + 1 as you did, then.
> 
> The patch looks good to me in the current state.

Sorry I don't get it (current patch):
int len = strlen(output_directory) + 4 + 6 + 4 + 1;
snprintf(pdf_name, len, "%s/dii%06d.pdf", output_directory,
email_sequence);

%s:strlen(output_directory)
"/dii": 4
%06d: 6
".pdf": 4
\0: 1

Will submit after this is resolved.