Re: memstat-0.9 hurd patch (PATH_MAX)
2012/1/23 Tanguy LE CARROUR <tanguy.lecarrour@gmail.com>:
> Hi Jérémie,
>
> Thanks for your comments!
> I'll have a look a it later this week but I've already learnt something: I'm
> a very bad developer! ^_^'
Don't worry, portability work is harder than it looks. Also, keep in
mind the whole point of patch review is to point out imperfections.
But it will teach you a lot because you get to read lots of code from
many different people, and your code will be read by many different
people as well.
Besides, as a first attempt your patch was nothing to be ashamed of! I
though your log10() trick was smart, if a little bit overkill :-)
--
Jérémie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org/
Reply to: