[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#686103: libetpan: FTBFS on hurd-i386



tags 686103 confirmed
forwarded 686103 https://github.com/dinhviethoa/libetpan/issues/40
thanks

On Tue, Aug 28, 2012 at 07:46:54PM +0200, Svante Signell wrote:
> On Tue, 2012-08-28 at 19:06 +0200, Philipp A. Hartmann wrote:
> > On 28/08/12 18:20, Svante Signell wrote:
> > > On Tue, 2012-08-28 at 18:14 +0200, Samuel Thibault wrote:
> > >> Svante Signell, le Tue 28 Aug 2012 17:55:07 +0200, a écrit :
> > >>> --- a/libetpan-config.h.in      2008-05-23 00:39:44.000000000 +0200
> > >>> +++ b/libetpan-config.h.in      2012-08-28 17:36:00.000000000 +0200
> > >>> @@ -15,6 +15,9 @@
> > >>>  #ifdef HAVE_LIMITS_H
> > >>>  @include <limits.h>
> > >>>  #endif
> > >>> +#ifndef PATH_MAX
> > >>> +@define PATH_MAX 4096
> > >>
> > >> Typo here.
> > > 
> > > No, @ is expanded to # when libetpan-config.h is created:
> > > cat ./libetpan-config.h.in | i486-gnu-gcc -E -I. - \
> > >         | sed -e '/^#/d;/^[ \t]*$/d;s/^@/#/' > libetpan-config.h
> > 
> > AFAICS, this would require to have '@'s in all added lines, since all
> > system includes are avoided by using the '@'.  You would then end up
> > with redefining PATH_MAX even on platforms where PATH_MAX is defined via
> > the skipped limits.h:
> > 
> > @ifndef PATH_MAX
> > @define PATH_MAX 4096
> > @endif
> 
> Yes, you are right. Adding this info to bug #686103, too.

  Thanks for the patch! Forwarding upstream because hurd unfortunately
is not a release candidate architecture (yet).

  regards,
-- 
  Ricardo Mones 
  ~
  The three principal virtues of a programmer are Laziness, 
  Impatience, and Hubris.                                    man perl

Attachment: signature.asc
Description: Digital signature


Reply to: