[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: libpst: FTBFS on hurd-i386 (for review)


On Wed, 2012-06-27 at 20:43 +0200, Svante Signell wrote:
> Source: libpst
> Version: 0.6.54-3
> Severity: important
> Tags: patch
> User: debian-hurd@lists.debian.org
> Usertags: hurd
> Hi, libpst does not build for GNU/Hurd due to PATH_MAX issues. Attached
> are three small patches to enable a successful build.
> libpst.c.patch checks for the availability of get_current_dir_name and
> user that function if available.
> pst2dii.cpp.in.patch avoids usage of PATH_MAX by dynamically allocating
> string buffers as needed. pst2dii will be built if  imagemagick
> (providing /usr/bin/convert)  and libgd2-noxpm-dev | libgd2-xpm-dev
> (providing gd.h and libgd) are installed, so a dependency on these needs
> to be added to debian/rules if building that executable.
> For patch2:
> Q1) I'm not sure if x=realloc(x,len) is OK. Better solution?

Maybe allocating the longest string, and use at two places?

> Q2) Should I include an updated debian/rules too (or remove patch 2
> completely)?

Reply to: