Re: Patch for libpst (for review)
On Thu, 2012-06-21 at 01:16 +0200, Guillem Jover wrote:
> Hi!
>
> On Wed, 2012-06-20 at 19:10:17 +0200, Svante Signell wrote:
> > If there is a need to build pst2dii that .cpp-file has to be patched too
> > (not done yet). Looks like it will be enabled if the right version
> > of /usr/bin/convert is found (probably from imagemagick). Not in the
> > build depends though. The /usr/bin/convert program I had installed
> > graphicsmagick-imagemagick-compat from was not the right one.
I wonder if there is interest also in pst2dii. In that case the package
would have bo build depend on imagemagick and libgd2-noxpm-dev |
libgd2-xpm-dev
> That patch has the problem (mentioned already on this list) that
> _GNU_SOURCE is a user defined macro, and AC_USE_SYSTEM_EXTENSIONS will
> unconditionally define it, so get_current_dir_name() would get used
> regardless of availability. Instead I'd recommend something like the
> following completely untested changes:
Sorry, I was misunderstanding your comment in a previous mail about
AC_USE_SYSTEM_EXTENSIONS, that is is non-conditional. Of course testing
for get_current_dir_name is better.
> I don't generally like this type of error unwinding, but that depends
> on the surrounding code, which I've not checked.
I'll create an updated patch according to your recommendations. However,
your patch seems to introduce more changes than I proposed.
Reply to: