[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: webkit-1.8.0-2: Patches for review

On Wed, 2012-04-18 at 10:27 +0200, Svante Signell wrote:

> > Your patch would make use of /proc/curproc/file, which would seem to be 
> > part of the FreeBSD procfs[1]; our procfs is more oriented to emulate 
> > Linux's one, so IMHO we should either use the Linux code, or add an 
> > empty getCurrentExecutablePath() like this:
> > 
> > | #elif OS(HURD)
> > | CString getCurrentExecutablePath()
> > | { return CString(); }
> Looks like neither /proc/curproc/file or /proc/self/exe exists for
> GNU/Hurd (any plans to add that??), so an empty function would be best.
> Agreed? If so I'll update the patch (and we don't have to care about the
> PATH_MAX stuff).

Is it OK to update the patch as Pino proposed?

FYI: webkit-1.8.0-2 built successfully with the updated path, not the
one proposed above. With the -gstabs option, the non-stripped libraries
reduce from >1.1G to <0.5G. However, the build still takes days...

Reply to: