[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#654381: icon: FTBFS on hurd-i386

Source: icon
Version: 9.4.3-3
Severity: important
Tags: patch
User: debian-hurd@lists.debian.org
Usertags: hurd


icon currently FTBFS on GNU/Hurd, see

The problems are a flaky fakeroot-tcp used by GNU/Hurd for the
Test-icont tests and a PATH setting issue in the Test-opts script.

The solution is to run the tests under the build target, not under the
binary target which is using fakeroot. The tests don't need to be
performed using fakeroot. The attached patch fixes these issues and
builds fine at least in the GNU/Hurd and the GNU/Linux i686+amd64


diff -ur ./icon-9.4.3/debian/rules icon-9.4.3.modified/debian/rules
--- ./icon-9.4.3/debian/rules	2012-01-03 09:25:09.000000000 +0100
+++ icon-9.4.3.modified/debian/rules	2012-01-03 10:49:52.000000000 +0100
@@ -67,10 +67,11 @@
 build-ipl: configure
 	$(MAKE) Ilib
+	touch build-ipl
-	-rm -f configure build-icont build-iconc build-ipl
+	-rm -f configure build-icont build-iconc build-ipl test-icont
 	-rm -rf debian/tmp-iconx debian/tmp-icont debian/tmp-iconc debian/tmp-ipl debian/files debian/*~ 
 	-rm -f bin/* debian/substvars
 	$(MAKE) Pure
@@ -197,7 +198,7 @@
 # And finally, build the Debian package!
 	dpkg --build debian/tmp-ipl ..
-test-icont: build-icont
+test-icont: build-icont build-ipl
 	@echo Tests for the Icon interpreter.
 	@echo First some simple tests to be sure Icon works.
@@ -205,6 +206,7 @@
 	@echo More exhaustive tests of various features of Icon and larger programs.
 	@echo  1. Basic tests. Should show only insignificant differences.
 	$(MAKE) Test-icont
+	touch test-icont
 test-iconc: build-iconc
@@ -224,7 +226,7 @@
 	$(MAKE) Benchmark-icont	
 build-iconx: build-icont
-build: build-icont build-iconc build-ipl
+build: build-icont build-iconc build-ipl test-icont
 binary-arch: binary-icont binary-iconx binary-iconc
diff -ur ./icon-9.4.3/tests/general/Test-opts icon-9.4.3.modified/tests/general/Test-opts
--- ./icon-9.4.3/tests/general/Test-opts	2005-10-05 18:37:46.000000000 +0200
+++ icon-9.4.3.modified/tests/general/Test-opts	2012-01-03 09:25:59.000000000 +0100
@@ -12,7 +12,7 @@
 ls ../../bin/icont >/dev/null || exit 1
 #  prepend Icon binary directory to path
 export PATH
 #  merge stdin and stderr

Reply to: