[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] avoid assuming MAXPATHLEN in config(8)



Hi Robert,

* Robert Millan <rmh@debian.org>, 20110707 11:33:
> config(8) assumes MAXPATHLEN is defined in a few places, but presence
> of this macro isn't garanteed (POSIX says that it is only present when
> a file length limit exists, which may not be the case).

Even though it is good to make our code conform to standards as much as
possible, do keep in mind that your patch also causes a lot of
regressions in that area. The code now uses asprintf(), which is not
part of POSIX. I also think the use of __GLIBC__ is frowned upon.

-- 
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

Attachment: pgplboL5XoGrV.pgp
Description: PGP signature


Reply to: