[debian-hurd-Patches][312118] libmusicbrainz-2.1 2.1.5
Patches item #312118, was changed at 30/11/2009 01:40 by Samuel Thibault
You can respond by visiting:
https://alioth.debian.org/tracker/?func=detail&atid=410472&aid=312118&group_id=30628
Status: Open
Priority: 3
Submitted By: Pino Toscano (pino-guest)
Assigned to: Nobody (None)
Summary: libmusicbrainz-2.1 2.1.5
Category: None
Group: None
Resolution: None
Initial Comment:
Adds the recognizing of the "gnu" system as supported, and a "dummy" stub of osdeps functions (like done for other OSes, eg QNX).
----------------------------------------------------------------------
>Comment By: Samuel Thibault (sthibault)
Date: 30/11/2009 02:46
Message:
Ok, please submit!
----------------------------------------------------------------------
Comment By: Pino Toscano (pino-guest)
Date: 30/11/2009 02:41
Message:
> Mmm, you can drop the <linux/cdrom.h> include entirely.
Done.
> in ReadTOC(), you could use strlen(device) instead of hardcoding
> the length
Right, done (malloc+free, as it isn't c99 code).
> (I guess QNX does it but that's not a reason ;) )
Not really, the QNX code does... exactly nothing ;)
----------------------------------------------------------------------
Comment By: Samuel Thibault (sthibault)
Date: 30/11/2009 02:10
Message:
Mmm, you can drop the <linux/cdrom.h> include entirely.
in ReadTOC(), you could use strlen(device) instead of hardcoding the
length (I guess QNX does it but that's not a reason ;) )
----------------------------------------------------------------------
You can respond by visiting:
https://alioth.debian.org/tracker/?func=detail&atid=410472&aid=312118&group_id=30628
Reply to: