[debian-hurd-Patches][312011] #550995: nss 3.12.4-1
Patches item #312011, was changed at 2009-10-14 15:44 by Michael Banck
You can respond by visiting:
https://alioth.debian.org/tracker/?func=detail&atid=410472&aid=312011&group_id=30628
Status: Open
Priority: 3
Submitted By: Pino Toscano (pino-guest)
Assigned to: Nobody (None)
>Summary: #550995: nss 3.12.4-1
Category: None
Group: None
Resolution: None
Initial Comment:
nss already has a 38_hurd.dpatch, but it covers only one file. Now nss FTBFS'es in another file as well, so I added the new fix in the existing patch.
Does it look sane enough to be reported on BTS?
----------------------------------------------------------------------
Comment By: Pino Toscano (pino-guest)
Date: 2009-10-14 21:24
Message:
Thanks for the review! Reported as bug #550995.
----------------------------------------------------------------------
Comment By: Samuel Thibault (sthibault)
Date: 2009-10-14 20:32
Message:
Should be fine, please submit, thanks!
----------------------------------------------------------------------
Comment By: Pino Toscano (pino-guest)
Date: 2009-10-14 19:22
Message:
Right-o, new hints merged into the new version.
----------------------------------------------------------------------
Comment By: Samuel Thibault (sthibault)
Date: 2009-10-14 18:04
Message:
actually you could now fold +1 into count itself, and there no need to
have a separate dir_len variable any more.
To avoid the
+#ifdef PATH_MAX
}
+#endif
you could #ifdef the if () only, without the {.
----------------------------------------------------------------------
Comment By: Pino Toscano (pino-guest)
Date: 2009-10-14 18:00
Message:
> Should be count+1 in snprintf
Fixed.
----------------------------------------------------------------------
Comment By: Samuel Thibault (sthibault)
Date: 2009-10-14 17:29
Message:
Should be count+1 in snprintf
----------------------------------------------------------------------
Comment By: Pino Toscano (pino-guest)
Date: 2009-10-14 17:03
Message:
Right, snprintf()'s back again.
----------------------------------------------------------------------
Comment By: Samuel Thibault (sthibault)
Date: 2009-10-14 16:11
Message:
I'd rather keep the snprintf as such, as it's more readable that
strcpys. Else it seems fine.
----------------------------------------------------------------------
You can respond by visiting:
https://alioth.debian.org/tracker/?func=detail&atid=410472&aid=312011&group_id=30628
Reply to: