[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[debian-hurd-Patches][310749] #479657 dancer-ircd patch



Patches item #310749, was opened at 2008-05-01 00:18
Status: Open
Priority: 3
Submitted By: Flávio Cruz (flaviocruz-guest)
Assigned to: Nobody (None)
>Summary: #479657 dancer-ircd patch 
Category: None
Group: None
Resolution: None


Initial Comment:
dancer-ircd-1.0.36 patch for GNU/Hurd

----------------------------------------------------------------------

Comment By: Samuel Thibault (sthibaul-guest)
Date: 2008-05-01 00:52

Message:
Mmm, sizeof(char) is 1 by C99 definition :)

Just a matter of taste: I would rather 

#define LOCK_SUFFIX ".lock"

and then use LOCK_SUFFIX and strlen(LOCK_SUFFIX), it is not so obvious
that lock_suffix_len is the length of lock_suffix.

I guess you have checked that only
ConfigFileEntry.{helpfile,motd,opermotd} need to be cleaned up.

Else the patch seems fine.


----------------------------------------------------------------------

You can respond by visiting: 
http://alioth.debian.org/tracker/?func=detail&atid=410472&aid=310749&group_id=30628


Reply to: