[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: pam patch



Hi,

I'm not a good programmer, but seeing what you did, I would say doing
things like
#ifndef PATHMAX
 <something>
#else
 <otherthing>
#endif
is bad: the dynamic way should be the only piece of code... And it would
be much more readable.

I think ideally, grep -r . -e PATH_MAX should only show the changelog
entry telling your patch made it disappear.

Snark on #hurd, #hurdfr



Reply to: