Re: pmake patch
On Tue, Sep 05, 2000 at 02:45:09AM -0400, Igor Khavkine wrote:
> Ok, i'll try it out. Having no internet for most of the last week did wonders
> for my development work. I was able to test out the pmake patch and also
> produce one for ash. I'm attaching it here. And I'll put it up on my page
> http://alcor.concordia.ca/~i_khavki/ with some comments that anyone who wants
> to review the patch should read.
It looks quite good. There is only one small glitch:
--- ash-0.3.7/miscbltin.c Sat Sep 2 18:04:01 2000
+++ ash-0.3.7.new/miscbltin.c Sat Sep 2 18:00:21 2000
@@ -69,7 +69,7 @@
#undef rflag
-#ifdef linux
+#if defined(__GLIBC__)
mode_t getmode(const void *, mode_t);
void *setmode(const char *);
The original code reads:
#ifdef linux
mode_t getmode(const void *, mode_t);
void *setmode(const char *);
#if !defined(__GLIBC__) || __GLIBC__ == 2 && __GLIBC_MINOR__ < 1
typedef enum __rlimit_resource rlim_t;
#endif
#endif
Note the second #if, which takes effect when you compile on an older linux
version with libc5 or libc4.
By changing from linux to __GLIBC__, you actually prevent the getmode and
setmode declarations on those platforms. Now you can either say, let's drop
support for those, and then you can remove the second, inner, #if block, or
remain compatible and change to #if defined(__GLIBC__) || defined(linux)
(or something similar).
Thanks,
Marcus
--
`Rhubarb is no Egyptian god.' Debian http://www.debian.org Check Key server
Marcus Brinkmann GNU http://www.gnu.org for public PGP Key
Marcus.Brinkmann@ruhr-uni-bochum.de, marcus@gnu.org PGP Key ID 36E7CD09
http://homepage.ruhr-uni-bochum.de/Marcus.Brinkmann/ brinkmd@debian.org
--
To UNSUBSCRIBE, email to debian-hurd-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Reply to: