Re: git: test suite fails on hppa, in run_with_limited_stack
On 2020-05-12 3:39 a.m., Greg Price wrote:
> I think it would indeed be sensible to simply disable these test cases
> on hppa. Here's how the prereq for them is defined:
> """
> test_lazy_prereq ULIMIT_STACK_SIZE '
> test_have_prereq !MINGW,!CYGWIN &&
> run_with_limited_stack true
> '
> """
>
> So perhaps that `!MINGW,!CYGWIN` bit can be straightforwardly extended
> to skip these tests on hppa too. If somebody would like to find the
> right incantation to put there for hppa, and test that it works, then
> I think that may be enough to get the Git test suite passing again on
> hppa.
>
Git built successfully with the attached change. There was a segv in one test run with
run_with_limited_cmdline, so I also disabled it.
Please install if okay.
Regards,
Dave
--
John David Anglin dave.anglin@bell.net
--- test-lib.sh.save 2020-05-12 16:10:31.266922345 +0000
+++ test-lib.sh 2020-05-12 17:25:39.548716911 +0000
@@ -1461,6 +1461,12 @@
test_set_prereq EXECKEEPSPID
;;
*)
+ uname_m=$(uname -m)
+ case $uname_m in
+ parisc*)
+ test_set_prereq HPPA
+ ;;
+ esac
test_set_prereq POSIXPERM
test_set_prereq BSLASHPSPEC
test_set_prereq EXECKEEPSPID
@@ -1606,7 +1612,7 @@
}
test_lazy_prereq CMDLINE_LIMIT '
- test_have_prereq !MINGW,!CYGWIN &&
+ test_have_prereq !HPPA,!MINGW,!CYGWIN &&
run_with_limited_cmdline true
'
@@ -1615,7 +1621,7 @@
}
test_lazy_prereq ULIMIT_STACK_SIZE '
- test_have_prereq !MINGW,!CYGWIN &&
+ test_have_prereq !HPPA,!MINGW,!CYGWIN &&
run_with_limited_stack true
'
Reply to: