Re: git: test suite fails on hppa, in run_with_limited_stack
Control: retitle -1 git: test suite fails on hppa, in run_with_limited_stack
Control: found -1 1:2.26.1-1
On Thu, 7 Aug 2014 16:10:20 -0400 John David Anglin
<dave.anglin@bell.net> wrote:
> run_with_limited_stack git tag --contains HEAD >actual &&
> [...]
> Killed
> not ok 136 - --contains works in a deep repo
Thanks for the report.
On Fri, 05 Sep 2014 23:12:26 +0200 Helge Deller <deller@gmx.de> wrote:
> git fails to build on hppa arch, because the stack is set to 64kb
> in the run_with_limited_stack() function for this test.
> I assume 64kb stack size is far too small for hppa....?
> Even /bin/ls won't work with a 128kb stack - so I'm not sure if
> this testcase should just be disabled for hppa (it's disabled on
> Windows because Windows does not support setting ulimits).
A few weeks after these reports, the stack size for these tests was
bumped to 128k upstream:
https://git.kernel.org/pub/scm/git/git.git/commit/?id=b9a190789
apparently in order to make it work on the m68k arch. (Commit message
copied below.)
But that wasn't enough on hppa, and the test suite is still failing
there with essentially the same issue. It appears now slightly
earlier, in another test 6120.70 (from t/t6120-describe.sh) which has
adopted the same technique. Here's the failure in the most recent
buildd log in unstable, on Git v2.26.1:
"""
expecting success of 6120.70 'describe works in a deep repo':
git tag -f far-far-away HEAD~7999 &&
echo "far-far-away" >expect &&
git describe --tags --abbrev=0 HEAD~4000 >actual &&
test_cmp expect actual &&
run_with_limited_stack git describe --tags --abbrev=0
HEAD~4000 >actual &&
test_cmp expect actual
Updated tag 'far-far-away' (was cb6ab2c)
Segmentation fault
not ok 70 - describe works in a deep rep
"""
https://buildd.debian.org/status/fetch.php?pkg=git&arch=hppa&ver=1%3A2.26.1-1&stamp=1586894380&raw=0
I think it would indeed be sensible to simply disable these test cases
on hppa. Here's how the prereq for them is defined:
"""
test_lazy_prereq ULIMIT_STACK_SIZE '
test_have_prereq !MINGW,!CYGWIN &&
run_with_limited_stack true
'
"""
So perhaps that `!MINGW,!CYGWIN` bit can be straightforwardly extended
to skip these tests on hppa too. If somebody would like to find the
right incantation to put there for hppa, and test that it works, then
I think that may be enough to get the Git test suite passing again on
hppa.
Cheers,
Greg
commit b9a1907899a2a00e94092207bb5de4d864408806
Author: Junio C Hamano <gitster@pobox.com>
Date: Tue Sep 23 15:41:38 2014 -0700
t7004: give the test a bit more stack space
It was reported that the allocated stack space was too small for
some archs openSUSE buildfarm runs the tests on. Double it while
also doubling the amount of data to be handled.
Reported-by: Andreas Schwab <schwab@linux-m68k.org>
Suggested-by: Jeff King <peff@peff.net>
Tested-by: Andreas Schwab <schwab@linux-m68k.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Reply to: