Re: glibc 2.24 testsuite issues on hppa

[John David Anglin <dave.anglin@bell.net>]

On 2016-08-05, at 6:23 PM, Aurelien Jarno wrote:

> I have looked at the testsuite results from the latest uploads, there
> are 9 real regressions (ie not new tests) mostly related to NPTL:
> 
> * FAIL: nptl/tst-default-attr
>    original exit status 22
>    stacksize test
>    guardsize test
>    sched test
>    tst-default-attr.c:101: pthread_create returned 22 (errno = 22)
>    tst-default-attr.c:371: do_sched_test returned 22 (errno = 22)

This was probably introduced by the following change:

2016-02-19  Carlos O'Donell  <carlos@systemhalted.org>

        * nptl/allocatestack.c (allocate_stack): Declare new stackaddr,
        assign attr->stackaddr to it, and adjust it down when
        _STACK_GROWS_UP.  Change all attr->stackaddr to stackaddr.
        [_STACK_GROWS_UP]: Delete assert.
        * nptl/pthread_create.c (START_THREAD_DEFN) [!_STACK_GROWS_DOWN]:
        Implement stack grows up logic.
        * nptl/pthread_getattr_np.c (pthread_getattr_np): Implement
        stack grows up logic.

I presume that the stack grows up patch that we had before was removed.  We are getting a mprotect error in test:

[pid 21422] mprotect(0xfce4a480, 4096, PROT_READ|PROT_WRITE|PROT_EXEC) = -1 EINVAL (Invalid argument)

It looks like the error comes from here in allocatestack.c:

#elif _STACK_GROWS_UP
          if (mprotect ((char *) pd - pd->guardsize,
                        pd->guardsize - guardsize, prot) != 0)
            goto mprot_error;
#endif

Dave
--
John David Anglin	dave.anglin@bell.net