Re: Fixed strace [ was Re: ls -l is broken ]

["John David Anglin" <dave@hiauly1.hia.nrc.ca>]

> On Tue, May 05, 2009 at 02:17:49PM -0400, John David Anglin wrote:
> > > (gdb) 
> > > #0  0x0002b3ec in __canonicalize_funcptr_for_compare ()
> > > #1  0x00026010 in sys_rt_sigaction (tcp=0x4e060) at ../signal.c:1886
> > > #2  0x00017b10 in trace_syscall (tcp=0x4e060) at ../syscall.c:2553
> > > #3  0x00016c98 in main (argc=<value optimized out>, argv=0xbff8202c)
> > >     at ../strace.c:2475
> > > 
> > > which is:
> > > 
> > >                 if (sa.__sigaction_handler.__sa_handler == SIG_ERR)
> > >                         tprintf("{SIG_ERR, ");
> > 
> > Is __canonicalize_funcptr_for_compare choking on SIG_ERR?  This is
> > a special value (-1).  The plabel bit is set.
> > 
> 
> Ahh, brilliant. Casting to long fixed it.

Probably, the cast should be to int.  __canonicalize_funcptr_for_compare
isn't used in the 64-bit runtime.

Still, I'm not sure why this fixed the problem as
__canonicalize_funcptr_for_compare checks for -1.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)