[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [parisc-linux] -pie is broken on hppa



On Sat, 2007-06-09 at 23:46 -0400, John David Anglin wrote:
> > This is what I see when I do a gcc_update:
> > dave@mx3210:~/gnu/gcc-4.3/gcc$ contrib/gcc_update
> > Updating SVN tree
> > At revision 125275.
> > svn: Can't read directory '.': Partial results are valid but processing is incomplete
> 
> I spent the day trying to debug why libjava fails to build on this system
> with the new glibc.  It seems that scandir is broken on 64-bit kernels.
> There seems to be an off by one error in copying dirent structs.  Either
> the define in <dirent.h> for _D_ALLOC_NAMLEN is wrong or the kernel
> sometimes returns a value for d_reclen that is sometimes too small.  The
> code in fs/readdir.c suggests that sys_parisc32.c needs fixing.
> 
> The enclosed seems to fix both the libjava build and the svn problem.
> Kyle's branch uses ALIGN instead of ROUND_UP.

This patch looks to be correct based on what's in
fs/compat.c:compat_sys_getdents()/compat_filldir()

But it does beg the question of why we're not using the generic compat
code in the first place?

James




Reply to: