[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RE: 2.4 64bit parisc patch for initscripts bug



Hi
Tested ok on my box, sorry for the delay --- demanding boss eating away at
my work time...

-----Original Message-----
From: Joel Soete [mailto:soete.joel@tiscali.be]
Sent: 30 July 2004 13:24
To: parisc-linux@parisc-linux.org
Cc: James Morris; debian-hppa@lists.debian.org
Subject: 2.4 64bit parisc patch for initscripts bug


Well that's will be better with at least a title and  the patch attached
(always bad webmail wrapping)

Thanks for you understand.

============================================================================
====

Hello *,

following pb encountered by James Morris (as describe in
<ttp://lists.debian.org/debian-hppa/2004/07/msg00009.html>),
I figure out that I forget to propose the Dave's patch for our platform.
I am not able to manage for 2.4 the big job that Matthew did for 2.6, also
i hope that this stuff will help:
--- linux-2.4.27-rc3-pa6mm/arch/parisc/kernel/sys_parisc32.c.Orig	2004-07-30
11:07:29.935992560 +0200
+++ linux-2.4.27-rc3-pa6mm/arch/parisc/kernel/sys_parisc32.c	2004-07-30
11:17:38.881418784 +0200
@@ -1195,14 +1195,13 @@
 	if (err)
 		goto out;

-	if (!type_page) {
-		err = -EINVAL;
-		goto out;
+	if (type_page) {
+		is_smb = !strcmp((char *)type_page, SMBFS_NAME);
+		is_ncp = !strcmp((char *)type_page, NCPFS_NAME);
+	} else {
+		is_smb = is_ncp = 0;
 	}

-	is_smb = !strcmp((char *)type_page, SMBFS_NAME);
-	is_ncp = !strcmp((char *)type_page, NCPFS_NAME);
-
 	err = copy_mount_stuff_to_kernel((const void *)(unsigned long)data,
&data_page);
 	if (err)
 		goto type_out;
========><========

I tested on 2.4.2[67] a time ago; it's also already applied in upstream
for sparc64 arch.

If it's ok for *,  can somebody ci (np cvs access)?

hth,
    Joel

PS: James, do you have the opportunity to test the 2.4 kernel with this
patch? (to be absolutly sure it solves the pb). Thanks in advance.



---------------------------------------------------------------------------
Tiscali ADSL LIGHT, 19,95 EUR/mois pendant 6 mois, c'est le moment de faire
le pas!
http://reg.tiscali.be/default.asp?lg=fr








Reply to: