[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1007095: marked as done (lmod: reproducible-builds: binary paths are embedded differently on usrmerge vs. non-usrmerge systems)

Your message dated Tue, 07 Jun 2022 00:52:01 +0000
with message-id <E1nyNRx-0009hU-A3@fasolo.debian.org>
and subject line Bug#1007095: fixed in lmod 8.6.19-1
has caused the Debian Bug report #1007095,
regarding lmod: reproducible-builds: binary paths are embedded differently on usrmerge vs. non-usrmerge systems
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1007095: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007095
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: lmod
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The paths to various binaries (readlink, ls, more) are embedded with
different paths when built on a usrmerge system vs. a non-usrmerge
system:

  https://tests.reproducible-builds.org/debian/rb-pkg/experimental/amd64/diffoscope-results/lmod.html

  /etc/profile.d/lmod.sh
 	 

  findExec·READLINK_CMD·/bin/readlink··readlink
  vs.
  findExec·READLINK_CMD·/usr/bin/readlink··readlink

The attached patch fixes this by passing configuration options and
variables to specify the paths to various binaries, using their
non-usrmerge locations, as compatibility symlinks generally exist for
one way, but not for the other.

This patch appears to only be relevent for the version currently in
experimental.


With this patch applied, lmod should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining lmod!

live well,
  vagrant

From 1132455b951464446f96b9ab78a77e1f5ca567eb Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 11 Mar 2022 02:02:34 +0000
Subject: [PATCH] debian/rules: Pass binary paths to configure to make the
 package build reproducibly regardless of usrmerge.

The binary paths for readlink, ls, and more should all point to their
non-usrmerge locations.

https://tests.reproducible-builds.org/debian/issues/paths_vary_due_to_usrmerge_issue.html
---
 debian/rules | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 172101a..c9670de 100755
--- a/debian/rules
+++ b/debian/rules
@@ -16,7 +16,10 @@ override_dh_auto_configure-arch:
 	dh_auto_configure -- \
 		--prefix=/usr/share \
 		--with-ModulePathInit=/etc/lmod/modulespath \
-		PS=/bin/ps
+		PS=/bin/ps \
+		READLINK=/bin/readlink \
+		PATH_TO_LS=/bin/ls \
+		PATH_TO_PAGER=/bin/more \
 
 override_dh_auto_configure-indep:
 
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: lmod
Source-Version: 8.6.19-1
Done: Andreas Beckmann <anbe@debian.org>

We believe that the bug you reported is fixed in the latest version of
lmod, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1007095@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <anbe@debian.org> (supplier of updated lmod package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 07 Jun 2022 02:35:28 +0200
Source: lmod
Architecture: source
Version: 8.6.19-1
Distribution: unstable
Urgency: medium
Maintainer: Debian HPC Team <debian-hpc@lists.debian.org>
Changed-By: Andreas Beckmann <anbe@debian.org>
Closes: 1007095
Changes:
 lmod (8.6.19-1) unstable; urgency=medium
 .
   * New upstream release.
 .
   [ Vagrant Cascadian ]
   * debian/rules: Pass binary paths to configure to make the package build
     reproducibly regardless of usrmerge.  (Closes: #1007095)
 .
   [ Andreas Beckmann ]
   * Update Standards-Version to 4.6.1.
   * Upload to unstable.
Checksums-Sha1:
 efa5efcac30928716f4436be405335060e7690bf 2696 lmod_8.6.19-1.dsc
 95fd1caa7a1ad2c793035dc33c5ca1e38a425235 59685 lmod_8.6.19.orig-hermes.tar.gz
 ae7fd2909f83a55699700c60ea342661feb52202 16027057 lmod_8.6.19.orig.tar.gz
 9b910138601f170dbf2ceda37c7495e0b3443ed2 7744 lmod_8.6.19-1.debian.tar.xz
 af24ebe02d766a469608591d167f7f6f1fcf3e4b 5433 lmod_8.6.19-1_source.buildinfo
Checksums-Sha256:
 4b423be96dfa94fc9826aaa7e0893177ca7d6b0549bee662effa83dfb6ef774b 2696 lmod_8.6.19-1.dsc
 ba837415293631aab85a8c87837f045a4fd0493861371f4c50c1bed05333105f 59685 lmod_8.6.19.orig-hermes.tar.gz
 219949ff2939374109225147140980991a8a1ba0efc57f2945af5677df65a93f 16027057 lmod_8.6.19.orig.tar.gz
 9c2c6bc08f84cd7fd65d2c80bc0bea0fa99aef504f207c6544eff8922a262815 7744 lmod_8.6.19-1.debian.tar.xz
 2520d92f2d5a516338b2681342b73af46885dc73381201c081b433e47bda2805 5433 lmod_8.6.19-1_source.buildinfo
Files:
 c4894a7e0bd61407f9067a81dc0b3570 2696 devel optional lmod_8.6.19-1.dsc
 4d28a6fd9f6d5ca042f3bab50d623cf5 59685 devel optional lmod_8.6.19.orig-hermes.tar.gz
 c794d46aa8a2d2b1a95d8449b12ab59d 16027057 devel optional lmod_8.6.19.orig.tar.gz
 4a0472c3cd8df4fb849c02f6a72bd952 7744 devel optional lmod_8.6.19-1.debian.tar.xz
 354a27cbf88d94d35c90dfa2de401570 5433 devel optional lmod_8.6.19-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAmKenc0QHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCPdzD/44eYIaL2+lFEmBTtXmy9J94c3QNPZCg31e
pGv47rYGPZFDcZznVh/a1Kqz2uIwuiYVy7X3Enh581VthrYlwH2YXjNKdk6yZNl8
O5Tknaod1HDVtqVZ2VwKkW/bUcJfIvgbcsnQYsMuLFvS06arHc/+wlNFQ4IJSR2u
euXt4fW3rxNqvtfwGtPCgYElv5xPzgaaSTu7kMIYJHIftci0BC4p9WEP6avTnE/o
VOb4PxeRSgs/3G2dCaieJmyIpH/cdzdw0nk8FSYwcH3YF/lJz0zq45EQdVY3gma8
JxtypHoqPFrmRhCc9Sjjlf5CybHzmM0jY0n5q5FIDeGOEd3yu3uZSPdjW4x/s5kr
in8vd71DwwYktdI0xWpmMKthsDS2/CPNjoashp4lOWnDO7DqeUL7E8XfnhYIuGLG
XrJyc2T/y+M1hj3KV/vAi3dlumBMsTWAaTGNLv5YMK6qFmmuDFz5afp7GIfih84Q
zNdrhg9ANif2e9d2v282Ih6iD594ARgAJIAAyWiZ+PiISY8y0qSuCOzskVQaNv5m
eviPpRAUDGdMf79tSLGo69o57LPPJripGnCJmmI2TXo/7Z1F7wnRhx1/Vy607Lf7
JYNg/ICHYqMBy0I24aROKU/kvep1q57ptjB5sxbOVokfUksDdThpygbTOkATeOKh
JOsXJbRZsA==
=vbb8
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: