[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#967901: lower memory usage for riscv build



Hey Aurélien, Jonas, thanks for the replies

Le 04/08/2020 à 19:11, Jonas Smedegaard a écrit :
> Closing this bugreport does not imply that conversation is closed, only 
> that with the currently presented material there is no further action.  
> We can continue the conversation in a "closed" bugreport.  You are still 
> most welcome to provide more information - e.g. more details on why (if 
> so) you think that it is relevant that Debian (not only Ubuntu) uses the 
> build flags that you requested.
>
> In addition to the (little) information presented here, I based my 
> judgement on some casual conversation on irc.  I explicitly asked there 
> to please share information in a bugreport but nothing came of that.

Sorry for the lack of informations and the ignorance of the context. I'm
not working on this package, just wanted to see it updated in Ubuntu so
went to do the merge and saw that the only diff we had was recent and
not forwarded to Debian so I did that.

I'm not familiar with riscv64 nor the difference between the Debian and
the Ubuntu port and why it would fail only in Ubuntu. From what I can
see the build was tried on
https://launchpad.net/ubuntu/+source/pandoc/2.8.1-2ubuntu1 and failed
after 2.5 days without letting a build log.

Then Dimitri (Cc here now) added a delta to --disable-optimization,
which he had done in a previous upload for armhf/arm64. Since I saw you
basically addressed a similar issue in Debian now with other flag I
though it would make sense to do the same on riscv64.

The build time are similarly slow on Debian but didn't fail at the end
so maybe the change is wrong there and more details are needed ...
Dimitri could you help there?

> Hope that helps.  A bit.  But yes, if ehat you need is to limit the 
> delta of Ubuntu packaging and that alone, then I really am not helping 
> here.
I've redone the patch to be an Ubuntu specific rules in debian/rules,
that shouldn't come to much cost to Debian and is quite common in other
packages [1]. If you believe it's wrong and that riscv64 shouldn't be
consider a low memory architecture / you don't want to carry a rule
specific to Ubuntu then it's your choice.

I will try to drop the delta and see if the build still fail and if we a
build log of the error

Cheers,
Sebastien Bacher

[1] https://codesearch.debian.net/search?q=dpkg-vendor+--is+Ubuntu&literal=1

diff -Nru pandoc-2.9.1.1/debian/changelog pandoc-2.9.1.1/debian/changelog
--- pandoc-2.9.1.1/debian/changelog	2020-07-30 15:31:00.000000000 +0200
+++ pandoc-2.9.1.1/debian/changelog	2020-08-04 17:10:56.000000000 +0200
@@ -1,3 +1,9 @@
+pandoc (2.9.1.1-4) unstable; urgency=medium
+
+  * debian/rules: reduce compile-time memory utilization on Ubuntu riscv
+
+ -- Sebastien Bacher <seb128@debian.org>  Tue, 04 Aug 2020 17:10:56 +0200
+
 pandoc (2.9.1.1-3) unstable; urgency=medium
 
   * tune build for weak targets:
diff -Nru pandoc-2.9.1.1/debian/rules pandoc-2.9.1.1/debian/rules
--- pandoc-2.9.1.1/debian/rules	2020-07-30 15:22:39.000000000 +0200
+++ pandoc-2.9.1.1/debian/rules	2020-08-04 17:10:56.000000000 +0200
@@ -182,6 +182,11 @@
 DEB_SETUP_GHC_CONFIGURE_ARGS += --ghc-options="-optc--param -optcggc-min-expand=10 -O0"
 endif
 
+# Reduce compile-time memory utilization on riscv for Ubuntu
+ifeq ($(shell dpkg-vendor --is Ubuntu && echo yes) $(DEB_HOST_ARCH), yes riscv64)
+DEB_SETUP_GHC_CONFIGURE_ARGS += --ghc-options="-optc--param -optcggc-min-expand=10 -O0"
+endif
+
 DEB_ENABLE_TESTS = yes
 DEB_SETUP_GHC_CONFIGURE_ARGS += $(if $(filter nocheck,$(DEB_BUILD_OPTIONS)),,-ftests)
 

Reply to: