[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: haskell-charsetdetect-ae on arm64

> it also fails on kfreebsd-*. Can you have a look there as well?

There the immediate problem is that
libcharsetdetect/nspr-emu/prcpucfg.h recognises kfreebsd-* with
neither defined(__linux__) nor defined(__FreeBSD__). It's possible
both would work, but I think the Linux way is safer as the macros
being tested and set relate to the userland. So, following the
suggestion given in
http://sourceforge.net/p/predef/wiki/OperatingSystems/, I'd suggest
this untested patch:

--- prcpucfg.h.orig
+++ prcpucfg.h
@@ -34,7 +34,7 @@
 #include "prcpucfg_win.h"
 #elif defined(__APPLE__)
 #include "prcpucfg_mac.h"
-#elif defined(__linux__)
+#elif defined(__linux__) || (defined(__FreeBSD_kernel__) && defined(__GLIBC__))
 #include "prcpucfg_linux.h"
 #elif defined(__FreeBSD__)
 #include "prcpucfg_freebsd.h"

> Also, this needs to go upstream somehow. Could you notify upstream at
> https://github.com/Aelve/charsetdetect-ae?

I'll see if I can create an "issue" there.


Reply to: