[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: FYI, extra-depends possibly broken



On 2015-06-01 17:28:02, Joachim Breitner wrote:
> Hi,
> 
> Am Sonntag, den 31.05.2015, 23:35 +0200 schrieb Iustin Pop:
> > Unless I'm mistaken, the extra-depends mechanism seems broken at the
> > moment, due to a bug introduced in the migration from makefiles rules to
> > Dh_Haskell.sh:
> > 
> >   $ debuild
> >   …
> >   dh_installdirs -plibghc-js-flot-dev 
> >   . /usr/share/haskell-devscripts/Dh_Haskell.sh && \
> >   install_dev_recipe "libghc-js-flot-dev"
> >   Running cd debian/tmp-inst-ghc
> >   Running mkdir -p usr/lib/haskell-packages/ghc/lib
> >   Running find usr/lib/haskell-packages/ghc/lib/ \( \! -name \*_p.a \! -name \*.p_hi \! -type d \) -exec install -Dm 644 \{\} ../libghc-js-flot-dev/\{\} \;
> >   Running install -Dm 644 js-flot-0.8.3.conf debian/libghc-js-flot-dev/var/lib/ghc/package.conf.d/js-flot-0.8.3.conf
> >   Running rm -f js-flot-0.8.3.conf
> >   /usr/share/haskell-devscripts/Dh_Haskell.sh: line 452: notdir: command not found
> >   Running mkdir -p debian//usr/lib/haskell-packages/extra-packages
> >   /usr/share/haskell-devscripts/Dh_Haskell.sh: line 453: debian/libghc-js-flot-dev/usr/lib/haskell-packages/extra-packages/js-flot-0.8.3: No such file or directory
> >   Running dh_haskell_provides -plibghc-js-flot-dev
> >   
> > With the result that the mechanism doesn't work - that, or I don't
> > understand how it's supposed to work, as the documentation is pretty
> > thin. I don't see any special configuration generated in the dev
> > package, so I presume it is broken.
> 
> I haven’t touched this either. Judging from the changelog, Giovanni
> Mascellani wrote this code. Gio, can you comment on that?
> 
> Iustin, did you see the manpage for dh_haskell_extra_depends? But as you
> say, it does not say a lot.

I saw the manpage, but it explains why it does what it does, and not
how; I'll try to come up with some improvements later. I would at least
to document what is the location and format of these files, and how to
declare extra depends for a package.

> > There's another bug in the same function, so before committing a fix: is
> > the mechanism expected to generate a file
> > /usr/lib/haskell-packages/extra-packages/$PACKAGE-$VERSION containing
> > dpendencies in apt format?
> 
> Judging from the manpage, that seems to be the idea.

OK, I pushed one commit fixing this issue to the git repo.

I don't know whether to ask why we don't use set -e for non-trivial
shell code, or to ask why do we use shell at all :)

I'll try to remember and push later in the week a new release. Until
then, all -data providing packages built with this version are broken.

thanks,
iustin

Attachment: signature.asc
Description: Digital signature


Reply to: