Hi, so here’s the review. Am Mittwoch, den 29.10.2014, 20:21 +0000 schrieb dxld@darkboxed.org: > --- old-haskell-monad-journal/control 1970-01-01 00:00:00.000000000 +0000 > +++ new-haskell-monad-journal/control 2014-10-29 20:21:29.363333818 +0000 > @@ -0,0 +1,69 @@ > +Source: haskell-monad-journal > +Section: haskell > +Priority: extra > +Maintainer: Debian Haskell Group <pkg-haskell-maintainers@lists.alioth.debian.org> > +Uploaders: Daniel Gröber <dxld@darkboxed.org> > +Build-Depends: debhelper (>= 9) > + , cdbs > + , haskell-devscripts (>= 0.8.15) > + , ghc > + , ghc-prof > + , libghc-mtl-dev (>=2.1) > + , libghc-transformers-dev (>= 0.3) > + , libghc-either-dev (>= 4.1) > + , libghc-monad-control-dev (>= 0.3) > + , libghc-transformers-base-dev (>= 0.4) These are missing the upper bounds in the build dependencies. A Cabal dependency of "== 0.3.*" turns into , libghc-transformers-dev (>= 0.3) , libghc-transformers-dev (<< 0.4) > --- old-haskell-monad-journal/copyright 1970-01-01 00:00:00.000000000 +0000 > +++ new-haskell-monad-journal/copyright 2014-10-29 20:21:29.363333818 +0000 > @@ -0,0 +1,59 @@ > +Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ > +Upstream-Name: monad-journal > +Upstream-Contact: Dimitri Sabadie <dimitri.sabadie@gmail.com> > +Source: http://hackage.haskell.org/package/monad-journal > + > +Files: * > +Copyright: 2014 Dimitri Sabadie > +License: > + Copyright (c) 2014, Dimitri Sabadie > + . > + All rights reserved. > + . > + Redistribution and use in source and binary forms, with or without > + modification, are permitted provided that the following conditions are met: > + . > + * Redistributions of source code must retain the above copyright > + notice, this list of conditions and the following disclaimer. > + . > + * Redistributions in binary form must reproduce the above > + copyright notice, this list of conditions and the following > + disclaimer in the documentation and/or other materials provided > + with the distribution. > + . > + * Neither the name of Dimitri Sabadie nor the names of other > + contributors may be used to endorse or promote products derived > + from this software without specific prior written permission. > + . > + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > +Files: debian/* > +Copyright: 2014 Daniel Gröber <dxld@darkboxed.org> > +License: GPL-3.0+ There is no point in licensing the (mostly trivial) contents of debian/ any different than the software you are packaging. (I believe there is no point in licensing it at all, but heh...) I suggest to use this low-maintenance text for packages: Files: debian/* Copyright: held by the contributors mentioned in debian/changelog License: <pkgname> license The same with the other packages. Otherwise it looks good! (I assume the garbled umlauts are a problem of the mail hook, and the files are proper UTF-8.) Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
Attachment:
signature.asc
Description: This is a digitally signed message part