[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-haskell-commits] darcs: haskell-devscripts: ghc-version-substvar



Hi,

thanks for working on haskell-devscripts.

Could you try to separate your changes into sepearate patches so that
they can be easlier reviewed? Darcs makes that really easy, just run
"darcs record" and select what you want in one patch, and repeat.


Am Mittwoch, den 28.05.2014, 21:50 +0000 schrieb Sven Bartscher:
> diff -rN -u old-haskell-devscripts/dh_haskell_depends new-haskell-devscripts/dh_haskell_depends
> --- old-haskell-devscripts/dh_haskell_depends	2014-05-28 21:50:10.860767989 +0000
> +++ new-haskell-devscripts/dh_haskell_depends	2014-05-28 21:50:10.868767989 +0000
> @@ -148,6 +148,7 @@
>      esac
>  
>      echo "haskell:Extra-Depends=`cat debian/extra-depends`" >> $sfile.tmp
> +    echo "haskell:ghc-version=`ghc --numeric-version`" >> $sfile.tmp
>  
>      mv $sfile.tmp $sfile
>  done

Is that the best solution? I was expecting a substvar that resolves to
something like
 ghc (>= 7.6.3), ghc (<< 7.6.3+)
or something else that you can use in the "Depends" line in
debian/control directly.

Also it might be unreliable to use ghc --numeric-version in the presence
of GHC snapshots, preleases and what not. I suggest to use the upstream
version of the actual Debian package here.

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: