Re: lens build failures
- To: Raúl Benencia <email@example.com>
- Cc: firstname.lastname@example.org
- Subject: Re: lens build failures
- From: Edward Kmett <email@example.com>
- Date: Mon, 28 Apr 2014 15:22:43 -0400
- Message-id: <CAJumaK8MLJ0dkEHhwkhndsLsZ+JgGsa1O=azMNSuqi8LHAQZ1A@mail.gmail.com>
- In-reply-to: <20140428190413.GC32145@hesperos>
- References: <CAJumaK8CzLoauW502BJa5Nkhw5-jsahPY6cgfzfVO+kqQWjwOQ@mail.gmail.com> <1398507928.2432.4.camel@kirk> <20140428190413.GC32145@hesperos>
A better fix might be to push down the no-TH machinery to the reflection package and add back the dependency.
The core of reflection should work fine without TH. It is just the splices for `int`, `nat` and the liftings of numeric instances that let you write `$(5)` to splice a type Nat that need to be disabled.
Also, it might be worth considering if thereis a problem with building the actual template-haskell library on stage1 or merely with using the LANGUAGE pragma for TemplateHaskell on stage1.
If it is just the latter I'd say you might consider including template-haskell, but hunting for the uses of the TemplateHaskell pragma instead.
That would excise a lot less tissue from the libraries. (e.g. reflection could run unmodified).
As an aside,
At least fix-doctest-float-implementations.diff isn't needed any more. We merged something like it a while ago.