Hi, Am Sonntag, den 04.11.2012, 18:19 +0100 schrieb Iustin Pop: > I've seen that, and I've already filled an issue for it > (https://github.com/kolmodin/hinotify/issues/3). That patch changes the > behaviour from catching only I/O errors to catching _all_ exceptions > (via SomeException), including ThreadKilled and UserInterrupt, because > the user who contributed the patch misunderstood the actual rationale > between the move from Prelude.catch to Control.Exception.catch. (Even > the old "catch all I/O errors" behaviour seems a bit strange…) > > My patch against the current version handles only I/O errors, keeping > the behaviour unchanged; I was thinking of uploading the current version > with a patch until I clarify the above with upstream. > > What do you think? very good code review, thanks. Nevertheless I would argue against introducing Debian-specific patches unless upstream is unwilling to fix the bug. So if the upstream behavior does not actually prevent you from doing something (e.g. FTBFS or some program just does not work or something equally serious), I’d recomment to upload upstream’s version unmodified and then follow up with a fixed upstream version as soon as that is released. In general divergence from upstream ought to be avoided, as it causes friction in the maintenance process. Providing upstream with a suggested fix is, of course, even better. Greetings, Joachim -- Joachim "nomeata" Breitner Debian Developer nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata
Attachment:
signature.asc
Description: This is a digitally signed message part