[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Thanks for your uploads, one minor suggestion



Dear Takaki,

great to see someone joining in the effort of the ghc migration, it is
very appreciated.

I was about to write something about committing your changes to Darcs,
but as I was writing, your commit messages arrived :-)

A minor note, though: You have uploaded this changelog:

$ less changelog 
haskell-hxt-unicode (9.0.1-1) unstable; urgency=low

  * New upstream release

 -- TANIGUCHI Takaki <takaki@debian.org>  Mon, 11 Apr 2011 16:18:24 +0900

haskell-hxt-unicode (9.0.0-2) UNRELEASED; urgency=low

  * Use ghc instead of ghc6

 -- Marco Silva <marcot@debian.org>  Sat, 15 Jan 2011 12:41:14 -0200

haskell-hxt-unicode (9.0.0-1) unstable; urgency=low

  * Initial release (Closes: #601836)

 -- TANIGUCHI Takaki <takaki@debian.org>  Thu, 28 Oct 2010 20:10:31 +0900


Ideally, if there are UNRELEASED changes and you create a new upstream
version, you should obtain this changelog:

haskell-hxt-unicode (9.0.1-1) unstable; urgency=low

  [ Marco Silva ]
  * Use ghc instead of ghc6

  [ TANIGUCHI Takaki]
  * New upstream release

 -- TANIGUCHI Takaki <takaki@debian.org>  Mon, 11 Apr 2011 16:18:24 +0900

haskell-hxt-unicode (9.0.0-1) unstable; urgency=low

  * Initial release (Closes: #601836)

 -- TANIGUCHI Takaki <takaki@debian.org>  Thu, 28 Oct 2010 20:10:31 +0900


In this case it did not really matter, but if there were Closes:-entries
in the UNRELEASED section, it would make a difference.

I suggest that you use debchange to add new entries, as that
automatically takes care of all these issues, e.g. "dch -v 9.0.1-1"
would have given you the above changelog entry. For that it is
recommended to put
DEBCHANGE_RELEASE_HEURISTIC=changelog
into ~/.devscripts.


Also, if you are motivated and have the time, feel free to upload any
packages http://release.debian.org/transitions/ghc7.html in bad or
unknown state.

Greetings and thanks,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: