[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ANN: cabal-debian et el



At Sat, 04 Apr 2009 12:21:57 +1100,
Trent W. Buck wrote:

> First bit of feedback:
> 
>     $ cabal-debian --debianize
>     cabal-debian: Missing value for --maintainer
>     $ cabal-debian --debianize --maintainer ${DEBEMAIL:-$EMAIL}
>     $
> 
> It seems to me that cabal-debian should default to using $DEBEMAIL (or
> $EMAIL), as other scripts do (e.g. bts(1)).

It already does, this is the code:

getDebianMaintainer :: Flags -> IO (Maybe String)
getDebianMaintainer flags =
    case debMaintainer flags of
      Nothing -> envMaintainer
      maint -> return maint
    where
      envMaintainer :: IO (Maybe String)
      envMaintainer =
          do env <- getEnvironment
             return $ do fullname <- lookup "DEBFULLNAME" env `mplus` lookup "NAME" env
                         email    <- lookup "DEBEMAIL" env `mplus` lookup "EMAIL" env
                         return (fullname ++ " <" ++ email ++ ">")

I have no explaination as to why it did not work for you -- it works for me :)

Do you have any ideas?

- jeremy

ps. I'll follow up on your other email later -- definitely some good suggestions.


Reply to: