[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

seeking review of pat 0.19.1



Hello debian-hams and tmancill --


I've packaged pat v0.19.1 and pushed my work to salsa.d.o .  I still plan some
more testing, but welcome review as there are cycles.

    https://tracker.debian.org/pkg/pat


There have been quite a bit of updates to pat since v0.16.0, including a
refactoring of code and a new dependency to golang-github-hashicorp-go-version
(which fortunately is already packaged in Debian).


Some questions/issues include (advise if these are better addressed OOB):

a) golang-github-hashicorp-go-version in Debian is 1.6.0 . 
   pat 0.19.1 released 2025-09-13 lists a dependency on 1.7.0 (but compiles ok
   with 1.6.0).
   Since then, a new hashicorp-go-version 1.8.0 was released 2025-11-28.

   I'm not clear how to best proceed.  Should I explore updating
   hashicorp-go-version to 1.7.0, or the latest 1.8.0, or is there a better
   path?


Per vendor-n8jja-pat-vara.patch

b) Looks like LICENSE, go.mod, and go.sum were relocated into the vara/ subdir
   instead of the parent dir as is the case with upstream.  Is there a reason
   for the move?

   I kept these files in the same location and manually updated with vimdiff
   the go.mod and go.sum files.

c) Was vara_test.go not included in the vendor subdirectory for a reason?  
   I left that file out, matching what was previously done.

d) How is vendor/modules.txt generated or created?
   I manually updated some of its meta data.

e) There is a renamed/relocated dependency-library in Pat-Vara:

   "github.com/imdario/mergo" is now listed as "dario.cat/mergo" in Pat-Vara/go.mod 

    Visiting https://dario.cat/mergo it's a link to
    https://pkg.go.dev/dario.cat/mergo which points to
    https://github.com/darccio/mergo (the same place that
    https://github.com/imdario/mergo points to).

    For now I'm using the old "mergo" name and URL (manually munging
    Pat-Vara/go.mod), to match the current Debian package
    golang-github-imdario-mergo .

    There is also a minor version challenge with golang-github-imdario-mergo.
    Pat-Vara v1.2.0 released 2025-06-16 depends on mergo v1.0.0 (unclear why
    the old version?!?).

    Debian package golang-github-imdario-mergo has v1.0.1 which was released
    2024-08-17 and packaged 2024-11-09.

    Upstream released v1.0.2 on 2025-05-07.

    For now things compile ok, but I'm still testing.  Again, welcome guidance
    on the best approach.

f) Is there a "shortcut" to updating vendor patches?  For now I'm using quilt
   push, then sha256sum and vimdiff against upstream git in another dir, then
   quilt refresh, and edits of patch meta-data.



Regards,
donfede

Attachment: signature.asc
Description: PGP signature


Reply to: