[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1089486: z8530-utils2: Supporting rootless builds by default

Source: z8530-utils2
Version: 3.0-1-11
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: niels@thykier.net
User: niels@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
z8530-utils2 failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]
  298 |         if (fgets(buf, sizeof(buf), fp) == NULL)
      |                   ^~~
      |                   |
      |                   unsigned char *
/usr/include/aarch64-linux-gnu/bits/stdio2.h:305:8: note: expected ‘char *’ but argument is of type ‘unsigned char *’ 305 | fgets (__fortify_clang_overload_arg (char *, __restrict, __s), int __n, 
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from sccparam.c:49:
sccutils.h: In function ‘check_version’:
sccstat.c:301:22: warning: pointer targets in passing argument 1 of ‘strncmp’ differ in signedness [-Wpointer-sign] 
  301 |         if (!strncmp(buf, MSG_NOTINIT, strlen(MSG_NOTINIT)))
      |                      ^~~
      |                      |
      |                      unsigned char *
sccutils.h:17:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 
   17 |         fgets(buf, sizeof(buf), fp);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from sccstat.c:36:
/usr/include/string.h:159:33: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ 
  159 | extern int strncmp (const char *__s1, const char *__s2, size_t __n)
      |                     ~~~~~~~~~~~~^~~~
sccstat.c:307:22: warning: pointer targets in passing argument 1 of ‘strncmp’ differ in signedness [-Wpointer-sign] 
  307 |         if (!strncmp(buf, MSG_NOCHIPS, strlen(MSG_NOCHIPS)))
      |                      ^~~
      |                      |
      |                      unsigned char *
/usr/include/string.h:159:33: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ 
  159 | extern int strncmp (const char *__s1, const char *__s2, size_t __n)
      |                     ~~~~~~~~~~~~^~~~
sccstat.c:318:42: warning: pointer targets in passing argument 2 of ‘strncmp’ differ in signedness [-Wpointer-sign] 
  318 |                         if (strncmp(dev, buf, strlen(dev)))
      |                                          ^~~
      |                                          |
      |                                          unsigned char *
/usr/include/string.h:159:51: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ 
  159 | extern int strncmp (const char *__s1, const char *__s2, size_t __n)
      |                                       ~~~~~~~~~~~~^~~~
sccstat.c:340:49: warning: pointer targets in passing argument 1 of ‘print_proc_kiss’ differ in signedness [-Wpointer-sign] 
  340 |                                 print_proc_kiss(buf);
      |                                                 ^~~
      |                                                 |
      |                                                 unsigned char *
sccstat.c:241:23: note: expected ‘char *’ but argument is of type ‘unsigned char *’ 
  241 | print_proc_kiss(char *buf)
      |                 ~~~~~~^~~
sccstat.c:343:50: warning: pointer targets in passing argument 1 of ‘print_proc_wregs’ differ in signedness [-Wpointer-sign] 
  343 |                                 print_proc_wregs(buf);
      |                                                  ^~~
      |                                                  |
      |                                                  unsigned char *
sccstat.c:264:24: note: expected ‘char *’ but argument is of type ‘unsigned char *’ 
  264 | print_proc_wregs(char *buf)
      |                  ~~~~~~^~~
sccstat.c:346:50: warning: pointer targets in passing argument 1 of ‘print_proc_rregs’ differ in signedness [-Wpointer-sign] 
  346 |                                 print_proc_rregs(buf);
      |                                                  ^~~
      |                                                  |
      |                                                  unsigned char *
sccstat.c:270:24: note: expected ‘char *’ but argument is of type ‘unsigned char *’ 
  270 | print_proc_rregs(char *buf)
      |                  ~~~~~~^~~
sccstat.c:349:50: warning: pointer targets in passing argument 1 of ‘print_proc_debug’ differ in signedness [-Wpointer-sign] 
  349 |                                 print_proc_debug(buf);
      |                                                  ^~~
      |                                                  |
      |                                                  unsigned char *
sccstat.c:276:24: note: expected ‘char *’ but argument is of type ‘unsigned char *’ 
  276 | print_proc_debug(char *buf)
      |                  ~~~~~~^~~
sccstat.c:352:24: warning: pointer targets in passing argument 1 of ‘fgets’ differ in signedness [-Wpointer-sign] 
  352 |         } while (fgets(buf, sizeof(buf), fp) != NULL);
      |                        ^~~
      |                        |
      |                        unsigned char *
/usr/include/aarch64-linux-gnu/bits/stdio2.h:305:8: note: expected ‘char *’ but argument is of type ‘unsigned char *’ 305 | fgets (__fortify_clang_overload_arg (char *, __restrict, __s), int __n, 
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from sccstat.c:49:
sccutils.h: In function ‘check_version’:
sccutils.h:17:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 
   17 |         fgets(buf, sizeof(buf), fp);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘fgets’,
    inlined from ‘main’ at sccinit.c:252:3:
/usr/include/aarch64-linux-gnu/bits/stdio2.h:316:12: warning: call to ‘__fgets_chk_warn’ declared with attribute warning: fgets called with bigger size than length of destination buffer [-Wattribute-warning] 
  316 |     return __fgets_chk_warn (__s, __sz, __n, __stream);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wall -g -Wl,-z,relro -O2 -Wall -g -Wstrict-prototypes kissbridge.c -o kissbridge 
kissbridge.c: In function ‘main’:
kissbridge.c:185:78: warning: pointer targets in passing argument 6 of ‘recvfrom’ differ in signedness [-Wpointer-sign] 185 | len = recvfrom(sock_fd, buf, sizeof(buf), 0, &saddr, &addrlen); | ^~~~~~~~ | | | int * 
In file included from /usr/include/aarch64-linux-gnu/sys/socket.h:343,
                 from kissbridge.c:26:
/usr/include/aarch64-linux-gnu/bits/socket2.h:69:56: note: expected ‘socklen_t * restrict’ {aka ‘unsigned int * restrict’} but argument is of type ‘int *’ 
   69 |           __SOCKADDR_ARG __addr, socklen_t *__restrict __addr_len)
      |                                  ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
kissbridge.c:140:24: warning: variable ‘t’ set but not used [-Wunused-but-set-variable] 
  140 |         struct timeval t;
      |                        ^
kissbridge.c: In function ‘kiss_encode’:
kissbridge.c:73:9: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 
   73 |         write(fd, mybuf, cnt2);
      |         ^~~~~~~~~~~~~~~~~~~~~~
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_installdirs
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_install
make -j4 install DESTDIR=/<<PKGBUILDDIR>>/debian/z8530-utils2 AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" 
make[2]: Entering directory '/<<PKGBUILDDIR>>'
install --strip-program=true -s -g root -o root -m 0755 -s gencfg /<<PKGBUILDDIR>>/debian/z8530-utils2/usr/bin/gencfg install: cannot change ownership of '/<<PKGBUILDDIR>>/debian/z8530-utils2/usr/bin/gencfg': Operation not permitted 
make[2]: *** [Makefile:27: install] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_install: error: make -j4 install DESTDIR=/<<PKGBUILDDIR>>/debian/z8530-utils2 AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true" returned exit code 2 
make[1]: *** [debian/rules:22: override_dh_auto_install] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:19: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 
--------------------------------------------------------------------------------
Build finished at 2024-11-18T21:56:44Z

-------------------------------------------------------------------------------


The above is just how the build ends and not necessarily the most
relevant part. If required, the full build log is available here:

https://people.debian.org/~nthykier/rrr-no-as-default/logs/1053477.gz

You can find common solutions at
https://people.debian.org/~nthykier/rrr-no-as-default/docs/solutions.md

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/static-ownership.list,
then please just set `Rules-Requires-Root: binary-targets` to the source
stanza of `debian/control` as a fix to this bug.

If this package is listed in
https://people.debian.org/~nthykier/rrr-no-as-default/docs/maybe-misbuilds.list,
then the package was deemed at risk for misbuilding (having wrong
ownership) but had a FTBFS problem we tested it. Please test whether the
package works with `Rules-Requires-Root: no` validating that the
resulting deb has the correct ownership for all paths in the deb.

The goal is to have the default changed in `dpkg` either in `Trixie` or
`Forky`, depending on progress and feasibility with the release schedule
for Trixie.

For more information on this bug filing, please see:
https://lists.debian.org/debian-dpkg/2024/11/msg00016.html

Thanks,


PS: The builds were performed in mid-November. If you fixed the problem
between between then and this bug being filed, then please just close
the bug with the version it was fixed in.

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply to: