[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1079651: marked as done (uronode FTCBFS: multiple reasons)



Your message dated Tue, 27 Aug 2024 21:36:32 +0000
with message-id <E1sj3rc-00Eazk-PI@fasolo.debian.org>
and subject line Bug#1079651: fixed in uronode 2.15-4
has caused the Debian Bug report #1079651,
regarding uronode FTCBFS: multiple reasons
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1079651: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1079651
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: uronode
Version: 2.15-3
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

uronode fails to cross build from source for multiple reasons. The build
runs the build architecture compiler and that fails badly. Usually, when
there is a configure script, we expect it to pick up the host from the
--host argument, but this is not what happens here. The buildsystem is
more similar to a bare Makefile based one where one passes cross tools
to make. Due to the presence of a configure script, dh_auto_build does
not pass cross tools here, but we can ask it to revert back to makefile
and pass cross tools. Then, in the install step the upstream Makefile
passes -s to install and that happens to use the build architecture
strip on host architecture ELF binaries, which doesn't work well either.
Ideally, we defer all stripping to dh_strip. Doing otherwise (as is done
here) also breaks DEB_BUILD_OPTIONS=nostrip as well as generation of
-dbgsym packages (both of which is broken here). The common way to
suppress the -s flag is passing an install with the --strip-program=true
and debhelper does this (for the makefile buildsystem). I'm attaching a
combined patch for your convenience fixing the cross build,
DEB_BUILD_OPTIONS=nostrip as well as generation of -dbgsym packages.

Helmut
diff --minimal -Nru uronode-2.15/debian/changelog uronode-2.15/debian/changelog
--- uronode-2.15/debian/changelog	2024-02-19 00:29:12.000000000 +0100
+++ uronode-2.15/debian/changelog	2024-08-25 10:45:15.000000000 +0200
@@ -1,3 +1,14 @@
+uronode (2.15-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Let the makefile buildsystem pass cross tools to make even though there
+      is a configure script involved.
+    + Let the makefile buildsystem pass a non-stripping install to make install.
+    + cross.patch: Honour the $(INSTALL) variable.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sun, 25 Aug 2024 10:45:15 +0200
+
 uronode (2.15-3) unstable; urgency=medium
 
   * Update my details
diff --minimal -Nru uronode-2.15/debian/patches/nostrip.patch uronode-2.15/debian/patches/nostrip.patch
--- uronode-2.15/debian/patches/nostrip.patch	1970-01-01 01:00:00.000000000 +0100
+++ uronode-2.15/debian/patches/nostrip.patch	2024-08-25 10:45:15.000000000 +0200
@@ -0,0 +1,105 @@
+--- uronode-2.15.orig/Makefile.in
++++ uronode-2.15/Makefile.in
+@@ -2,6 +2,7 @@
+ 
+ CC = gcc
+ LD = $(CC)
++INSTALL ?= install
+ # CFLAGS = -O2 -g -s -Wno-unused-result -Wstrict-prototypes
+ # CFLAGS = -DUNIX -g3 -DDEBUG
+ CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
+@@ -30,55 +31,55 @@
+ 	$(CC) $(CPPFLAGS) $(CFLAGS) $(CXXFLAGS) $(LDFLAGS)  -c $<
+ 
+ install: installbin installman installhelp installconf
+-	install -b -m 755    -D -d	$(VAR_DIR)
+-	install -b -m 755    -D -d	$(VAR_DIR)/node
+-	install -b -m 644    -p etc/loggedin	$(VAR_DIR)/node
+-	install -b -m 644    -p etc/lastlog	$(VAR_DIR)/node
+-	install -b -m 755    -D -d	$(VAR_DIR)/flex
+-	install -b -m 644    -p etc/gateways	 $(VAR_DIR)/flex
++	$(INSTALL) -b -m 755    -D -d	$(VAR_DIR)
++	$(INSTALL) -b -m 755    -D -d	$(VAR_DIR)/node
++	$(INSTALL) -b -m 644    -p etc/loggedin	$(VAR_DIR)/node
++	$(INSTALL) -b -m 644    -p etc/lastlog	$(VAR_DIR)/node
++	$(INSTALL) -b -m 755    -D -d	$(VAR_DIR)/flex
++	$(INSTALL) -b -m 644    -p etc/gateways	 $(VAR_DIR)/flex
+ 	
+ installbin: all
+-	install -b -m 755    -D -d		$(SBIN_DIR)
+-	install -m 755 	-s -p	uronode		$(SBIN_DIR)
+-	install -m 755  -s -p	nodeusers	$(SBIN_DIR)
+-	install -m 755  -s -p	axdigi		$(SBIN_DIR)
+-	install -m 755	-s -p	calibrate	$(SBIN_DIR)
+-@IN@	install -m 755  -s -p	flexd		$(SBIN_DIR)
++	$(INSTALL) -b -m 755    -D -d		$(SBIN_DIR)
++	$(INSTALL) -m 755 	-s -p	uronode		$(SBIN_DIR)
++	$(INSTALL) -m 755  -s -p	nodeusers	$(SBIN_DIR)
++	$(INSTALL) -m 755  -s -p	axdigi		$(SBIN_DIR)
++	$(INSTALL) -m 755	-s -p	calibrate	$(SBIN_DIR)
++@IN@	$(INSTALL) -m 755  -s -p	flexd		$(SBIN_DIR)
+ 
+ installhelp:
+-	install -b -m 755    -D -d		 $(VAR_DIR)
+-	install -b -m 755    -D -d		 $(VAR_DIR)/node/help
+-	install -b -m 644    -p etc/help/*.hlp $(VAR_DIR)/node/help
++	$(INSTALL) -b -m 755    -D -d		 $(VAR_DIR)
++	$(INSTALL) -b -m 755    -D -d		 $(VAR_DIR)/node/help
++	$(INSTALL) -b -m 644    -p etc/help/*.hlp $(VAR_DIR)/node/help
+ 
+ installconf: installhelp
+-	install -b -m 755    -D -d		 $(ETC_DIR)
+-	install -b -m 600    -p etc/uronode.announce  $(ETC_DIR)
+-	install -b -m 600    -p etc/uronode.conf  $(ETC_DIR)
+-	install -b -m 600    -p etc/uronode.perms $(ETC_DIR)
+-	install -b -m 600    -p etc/uronode.info  $(ETC_DIR)
+-	install -b -m 600    -p etc/uronode.motd  $(ETC_DIR)
+-	install -b -m 600    -p etc/uronode.users $(ETC_DIR)
+-	install -b -m 600    -p etc/uronode.routes   $(ETC_DIR)
+-	install -b -m 600    -p etc/flexd.conf  $(ETC_DIR)
++	$(INSTALL) -b -m 755    -D -d		 $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.announce  $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.conf  $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.perms $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.info  $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.motd  $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.users $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.routes   $(ETC_DIR)
++	$(INSTALL) -b -m 600    -p etc/flexd.conf  $(ETC_DIR)
+ 
+ installman:
+-	install -m 755	  -D -d $(MAN_DIR)/man1 $(MAN_DIR)/man5 $(MAN_DIR)/man8
+-	install -m 644    -p man/nodeusers.1  $(MAN_DIR)/man1
+-	install -m 644    -p man/uronode.conf.5  $(MAN_DIR)/man5
+-	install -m 644    -p man/uronode.perms.5 $(MAN_DIR)/man5
+-	install -m 644    -p man/flexd.conf.5 $(MAN_DIR)/man5
+-	install -m 644    -p man/uronode.8       $(MAN_DIR)/man8
+-	install -m 644	  -p man/calibrate.8	 $(MAN_DIR)/man8
+-	install -m 644	  -p man/axdigi.8	 $(MAN_DIR)/man8
+-	install -m 644	  -p man/flexd.8	 $(MAN_DIR)/man8
++	$(INSTALL) -m 755	  -D -d $(MAN_DIR)/man1 $(MAN_DIR)/man5 $(MAN_DIR)/man8
++	$(INSTALL) -m 644    -p man/nodeusers.1  $(MAN_DIR)/man1
++	$(INSTALL) -m 644    -p man/uronode.conf.5  $(MAN_DIR)/man5
++	$(INSTALL) -m 644    -p man/uronode.perms.5 $(MAN_DIR)/man5
++	$(INSTALL) -m 644    -p man/flexd.conf.5 $(MAN_DIR)/man5
++	$(INSTALL) -m 644    -p man/uronode.8       $(MAN_DIR)/man8
++	$(INSTALL) -m 644	  -p man/calibrate.8	 $(MAN_DIR)/man8
++	$(INSTALL) -m 644	  -p man/axdigi.8	 $(MAN_DIR)/man8
++	$(INSTALL) -m 644	  -p man/flexd.8	 $(MAN_DIR)/man8
+ 
+ upgrade: installbin installman installhelp
+-	install -b -m 600    -p etc/uronode.announce  $(ETC_DIR)
+-	install -m 755 -p uronode       $(SBIN_DIR)
+-	install -m 755 -p nodeusers     $(SBIN_DIR)
+-	install -m 755 -p calibrate	$(SBIN_DIR)
+-@IN@	install -m 755 -p flexd		$(SBIN_DIR)
+-	install -m 755 -p axdigi	$(SBIN_DIR)
++	$(INSTALL) -b -m 600    -p etc/uronode.announce  $(ETC_DIR)
++	$(INSTALL) -m 755 -p uronode       $(SBIN_DIR)
++	$(INSTALL) -m 755 -p nodeusers     $(SBIN_DIR)
++	$(INSTALL) -m 755 -p calibrate	$(SBIN_DIR)
++@IN@	$(INSTALL) -m 755 -p flexd		$(SBIN_DIR)
++	$(INSTALL) -m 755 -p axdigi	$(SBIN_DIR)
+ 
+  
+ clean:
diff --minimal -Nru uronode-2.15/debian/patches/series uronode-2.15/debian/patches/series
--- uronode-2.15/debian/patches/series	2024-02-19 00:29:12.000000000 +0100
+++ uronode-2.15/debian/patches/series	2024-08-25 10:45:15.000000000 +0200
@@ -5,3 +5,4 @@
 folder-update
 install-dir-creation
 
+nostrip.patch
diff --minimal -Nru uronode-2.15/debian/rules uronode-2.15/debian/rules
--- uronode-2.15/debian/rules	2024-02-19 00:29:12.000000000 +0100
+++ uronode-2.15/debian/rules	2024-08-25 10:45:15.000000000 +0200
@@ -10,4 +10,7 @@
 
 override_dh_auto_build:
 	cat CHANGES.* > changelog
-	dh_auto_build
+	dh_auto_build --buildsystem=makefile
+
+override_dh_auto_install:
+	dh_auto_install --buildsystem=makefile

--- End Message ---
--- Begin Message ---
Source: uronode
Source-Version: 2.15-4
Done: Dave Hibberd <hibby@debian.org>

We believe that the bug you reported is fixed in the latest version of
uronode, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1079651@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dave Hibberd <hibby@debian.org> (supplier of updated uronode package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 27 Aug 2024 22:09:25 +0100
Source: uronode
Architecture: source
Version: 2.15-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Dave Hibberd <hibby@debian.org>
Closes: 1079651
Changes:
 uronode (2.15-4) unstable; urgency=medium
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #1079651)
     + Let the makefile buildsystem pass cross tools to make even though there
       is a configure script involved.
     + Let the makefile buildsystem pass a non-stripping install to make install.
     + cross.patch: Honour the $(INSTALL) variable.
 .
   [ Dave Hibberd ]
   * Applied debdiff
   * Bumped Standards
Checksums-Sha1:
 2e29b556d0b90d4248b108346d2df1ac31f7edc1 1595 uronode_2.15-4.dsc
 c535423687d5daf199bef7b02a618abcf96bae87 6316 uronode_2.15-4.debian.tar.xz
 eca2335d26533751ff4d48f442e3bb21e6e653ac 5670 uronode_2.15-4_amd64.buildinfo
Checksums-Sha256:
 8834f7895f4669fa9979aad88fb26bbcdf7f1d99179d3b948a8aba1fb0c58490 1595 uronode_2.15-4.dsc
 2fdfdf0762692968710e2a2b46743ab0ef9411cace3d89b602ee125f08210f32 6316 uronode_2.15-4.debian.tar.xz
 4a9c7df2cb68379e3c2e6864a92b9cbde3fde75944c142f3abe74d3f16c8fff6 5670 uronode_2.15-4_amd64.buildinfo
Files:
 fc49202ee853fdcfe63726198b1decfa 1595 hamradio optional uronode_2.15-4.dsc
 78d1a3f37b5388a0e00a97456faf3b4b 6316 hamradio optional uronode_2.15-4.debian.tar.xz
 85a1973f239cd2f872d3c13dd30eb986 5670 hamradio optional uronode_2.15-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEXk9UUZPolpyKWbgKA6H7ehkEdxsFAmbOQasACgkQA6H7ehkE
dxsbbgf9FPAgW7AKOjONoMOnYFKgDqbVeOsIN1kjMAFoOwX54h8KTfj8jg6UUD39
81bvYuRGFeq0QIzHwaqqK8+MDoLth35SoESz6ixkbn4RrBqynejDT5g9fWsYq/hl
gsQmODQQUUWmmmEnKGgjC+FtyuoOZU7+25rm4/tnplDmKS9s5v4erRXMY6XOozD9
xtz+F9e0tBmulAw+D4S33Ik56CZAoXPkZCJEPne64JGv2ZwltaDPhzvBaEwx827w
GYtxoPHifV6qiUfPqYk6LO9d15uDWedliegCiHg4RI3OA9Uoi4vS5tzHs30bgiWM
SrhTcaDHn+8XRoVwLWDiiZNcg1SgiA==
=v7lk
-----END PGP SIGNATURE-----

Attachment: pgpOJjBBS3na0.pgp
Description: PGP signature


--- End Message ---

Reply to: