[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1064298: marked as done (libhamlib4t64: ineffective replaces due to /usr-move)

Your message dated Wed, 21 Feb 2024 04:50:34 +0000
with message-id <E1rceZ0-003t5E-7O@fasolo.debian.org>
and subject line Bug#1064298: fixed in hamlib 4.5.5-3.1~exp2
has caused the Debian Bug report #1064298,
regarding libhamlib4t64: ineffective replaces due to /usr-move
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1064298: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064298
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libhamlib4t64
Version: 4.5.5-3.1~exp1
Severity: serious
Tags: patch
User: helmutg@debian.org
Usertags: dep17p1
Control: affects -1 + libhamlib4
X-Debbugs-Cc: vorlon@debian.org, mwhudson@debian.org

libhamlib4t64 introduced Replaces for libhamlib4 to take over its files
and in that process it also takes over
/usr/lib/udev/rules.d/60-libhamlib4.rules. This file also is in
libhamlib4 in an aliased location. Moving a file from / to /usr and
between packages causes file loss (DEP17 P1). Hence, I'm extending the
existing mitigation for DEP17 P7 (M-A:same shared file loss) to cover
the new P1 problem introduced by time64. See my attched patch. The
protective diversion will be kept beyond postinst and stay around. Since
the earlier diversion in libhamlib4 was removed in postinst, there
cannot be any conflict on diversions. I tested the upgrade using
piuparts.

Helmut

diff --minimal -Nru hamlib-4.5.5/debian/changelog hamlib-4.5.5/debian/changelog
--- hamlib-4.5.5/debian/changelog	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/changelog	2024-02-19 19:50:40.000000000 +0100
@@ -1,3 +1,11 @@
+hamlib (4.5.5-3.1~exp1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Extend DEP17 P7 mitigation (protective diversion for udev rules) to also
+    cover P1 (package rename). (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 19 Feb 2024 19:50:40 +0100
+
 hamlib (4.5.5-3.1~exp1) experimental; urgency=medium
 
   * Non-maintainer upload.
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides
--- hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.lintian-overrides	2024-02-19 19:50:40.000000000 +0100
@@ -1,4 +1,4 @@
 # protective diversion for upgrades of files moved from / to /usr
 # see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1056692
-libhamlib4t64: diversion-for-unknown-file lib/udev/rules.d/60-libhamlib4t64.rules [preinst:14]
+libhamlib4t64: diversion-for-unknown-file lib/udev/rules.d/60-libhamlib4.rules [preinst:*]
 libhamlib4t64: package-name-doesnt-match-sonames libhamlib4
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.postinst hamlib-4.5.5/debian/libhamlib4t64.postinst
--- hamlib-4.5.5/debian/libhamlib4t64.postinst	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.postinst	2024-02-19 13:56:14.000000000 +0100
@@ -7,17 +7,6 @@
 
 rm -f /etc/udev/rules.d/60-libhamlib4.rules
 
-# begin-remove-after: released:forky
-# protective diversion of files moved from / to /usr, to avoid file loss.
-# Only for upgrades.
-if [ "$1" = "configure" ]; then
-    # At this point, the package will have installed the same file in */usr*.
-    dpkg-divert --package usr-is-merged --no-rename \
-        --divert /lib/udev/rules.d/60-libhamlib4.rules.usr-is-merged \
-        --remove /lib/udev/rules.d/60-libhamlib4.rules
-fi
-# end-remove-after
-
 #DEBHELPER#
 
 exit 0
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.postrm hamlib-4.5.5/debian/libhamlib4t64.postrm
--- hamlib-4.5.5/debian/libhamlib4t64.postrm	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.postrm	2024-02-19 13:56:50.000000000 +0100
@@ -5,16 +5,13 @@
 
 dpkg-maintscript-helper rm_conffile /etc/udev/60-libhamlib4.rules -- "$@"
 
-# begin-remove-after: released:forky
 # protective diversion of files moved from / to /usr, to avoid file loss.
 # Only for upgrades.
 if [ "$1" = "remove" ] && [ "$DPKG_MAINTSCRIPT_PACKAGE_REFCOUNT" = "1" ]; then
-    # Cleanup in case package is removed before upgrade is finished (postinst ran).
     dpkg-divert --package usr-is-merged --no-rename \
         --divert /lib/udev/rules.d/60-libhamlib4.rules.usr-is-merged \
         --remove /lib/udev/rules.d/60-libhamlib4.rules
 fi
-# end-remove-after
 
 #DEBHELPER#
 
diff --minimal -Nru hamlib-4.5.5/debian/libhamlib4t64.preinst hamlib-4.5.5/debian/libhamlib4t64.preinst
--- hamlib-4.5.5/debian/libhamlib4t64.preinst	2024-02-17 04:43:05.000000000 +0100
+++ hamlib-4.5.5/debian/libhamlib4t64.preinst	2024-02-19 13:55:31.000000000 +0100
@@ -5,15 +5,13 @@
 
 dpkg-maintscript-helper rm_conffile /etc/udev/60-libhamlib4.rules -- "$@"
 
-# begin-remove-after: released:forky
 # protective diversion of files moved from / to /usr, to avoid file loss.
-# Only for upgrades.
-if [ "$1" = "upgrade" ]; then
+if [ "$1" = upgrade ] || [ "$1" = install ]; then
+    # The diversion should be removed after trixie is released.
     dpkg-divert --package usr-is-merged --no-rename \
         --divert /lib/udev/rules.d/60-libhamlib4.rules.usr-is-merged \
         --add /lib/udev/rules.d/60-libhamlib4.rules
 fi
-# end-remove-after
 
 #DEBHELPER#

--- End Message ---
--- Begin Message --- 
Source: hamlib
Source-Version: 4.5.5-3.1~exp2
Done: Steve Langasek <vorlon@debian.org>

We believe that the bug you reported is fixed in the latest version of
hamlib, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1064298@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve Langasek <vorlon@debian.org> (supplier of updated hamlib package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 17 Feb 2024 03:43:05 +0000
Source: hamlib
Built-For-Profiles: noudeb
Architecture: source
Version: 4.5.5-3.1~exp2
Distribution: experimental
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Steve Langasek <vorlon@debian.org>
Closes: 1064298
Changes:
 hamlib (4.5.5-3.1~exp2) experimental; urgency=medium
 .
   * Non-maintainer upload.
   * Rename libraries for 64-bit time_t transition.
 .
   [ Helmut Grohne ]
   * Extend DEP17 P7 mitigation (protective diversion for udev rules) to also
     cover P1 (package rename). (Closes: #1064298)
Checksums-Sha1:
 d571211c30f7a0ee962974ffc9f5eb76fd26a466 3098 hamlib_4.5.5-3.1~exp2.dsc
 c9ecb1243339f9feb967630a0d28619bf060299b 28184 hamlib_4.5.5-3.1~exp2.debian.tar.xz
 30f0d4eb04aa6378d5c94bf228a96241436ed465 9059 hamlib_4.5.5-3.1~exp2_source.buildinfo
Checksums-Sha256:
 206bce51fbae31df4f144be20776887a2e1f2ca9810de00de0d8021f7f99ea47 3098 hamlib_4.5.5-3.1~exp2.dsc
 27931e77d4ebf155a505d74afbc9f62d46023a475cdbf45d09f7e6a3cdcfd907 28184 hamlib_4.5.5-3.1~exp2.debian.tar.xz
 d1cffd398a90a1d4fbc27f52ad754cbb50dc247da442c5a3c058f6424b7fdc48 9059 hamlib_4.5.5-3.1~exp2_source.buildinfo
Files:
 852fd1de49263c2dad46f032be126a86 3098 hamradio optional hamlib_4.5.5-3.1~exp2.dsc
 25da9a18c673e1fe24793193dd5266b1 28184 hamradio optional hamlib_4.5.5-3.1~exp2.debian.tar.xz
 e91ed8a72229cd5e78b823e23312b361 9059 hamradio optional hamlib_4.5.5-3.1~exp2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEiiBE+E9xaoW3f/djEd9ClMyjmJMFAmXVXNIACgkQEd9ClMyj
mJPiqA//fk43KyNz7AG/Uz4gHhoMx4sZERR0YWXU0yKkwXYfXoGy9ZZruAwTfg3d
ifbvZXHaf5CmJb0uzMdEtaziTCgLaCoAOm/rlBjCtl9KVcOYc2GLMH1w6QNddLEb
830c8CUxLxyt/fsqVjcl8IBomd6k5ywX0X48zSh3NcwVlCDJrNZWSGtb07gQ2vV3
fADB4SNkl6TwMAXVMm8ZLsoAcNE3g03y3vZwFuEpdAvAtRGL+ajBdqgdov59KR41
cQ/vsYsaOZQvF1FYRXqe0hPYf0tDlxuCbfmn48ZD4RwYemXLEL7ZUX4PxlUkmdlw
VFIfPZ1RfdtPq0KncPOPSW3cuD4+32j8E0kVl5C0V9FjFd+RomKFnfYiMNeMqwCP
l+nFeQam5ZTW8YeNRbbXOhfqf1p03g5+586FgU8G9eGO7BMW7ruDHIeJoB6g6ejZ
H0bjES3iFUZRAEEw+gVjoSA07BsTOSLWTL09Z7KaW/c2XZK0aC2KIfIchSJcfJDQ
gjyOsG4xxVEu9zffcwIq5B46d2YziMaZIg5B9Q7cW+Hy3vfQyHXsQMqz56eROTWD
8Arp1pOHf1FAS9qPIWUWHDLgRDVUUm159OiutpSchMF2+HqprT2wo3nVQ4cESGt2
uW4eIKuwozbuQGM8pLuddUoaJBNZxcb0bKDuHG8mk7O2pLILqFQ=
=AdfP
-----END PGP SIGNATURE-----

Attachment: pgpo1XyGQWoAC.pgp
Description: PGP signature


--- End Message ---
Reply to: