Hi there!
Yeah I’ve pushed his patch already to our git, so if anyone else on the team wants to upload it they can - I am still waiting on our account managers to finalise my Debian developer application before I have free reign to upload things, and I’ll switch this package to fall under my ownership like a collection of other packet things to make life a little easier going forward.
Cheers DH On 1 Jan 2024, at 16:46, David Ranch <dranch@trinnet.net> wrote:
Hello DaveH,
I have pushed the required fixes to the develop branch of Linpac.
I do plan on adding some other enhancements to Linpac before
publishing an new official release but I don't know if getting out
this fix is important to the Debian release process. Maybe the
similar third party fix offered by Sven is
good enough for now to keep Linpac in the Debian Unstable/Testing
repos?
--David
KI6ZHD
On 12/18/2023 02:40 AM, Dave Hibberd
wrote:
Hi both,
I'll prepare
a team upload for this in advance of the new upstream release
(thanks David), and upload it independently or with support
depending on the outcome of the DAM stage of my NM process ( https://nm.debian.org/process/1224/)
Cheers
DH
On Sat, 16 Dec 2023, at 6:32 PM, David Ranch wrote:
Hello Sven, Debian team,
I was about to apply a very similar fix to the "develop"
branch of Linpac at https://sourceforge.net/p/linpac/linpac/ci/develop/tree
though my changes didn't include the "-1" at the end of the
changes. Not sure if that's needed / important.
Regardless, I am planning to eventually merge the develop
branch into the Master branch and releae 0.29 in the near
future which will include this and other fixes.
--David
KI6ZHD
On 12/16/2023 10:01 AM, Sven
Joachim wrote:
Control: tags -1 + patch
On 2023-12-05 23:07 +0100, Santiago Vila wrote:
Package: src:linpac
Version: 0.28-2
Severity: serious
Tags: ftbfs
Dear maintainer:
During a rebuild of all packages in unstable, your package failed to build:
--------------------------------------------------------------------------------
[...]
g++ -DHAVE_CONFIG_H -I. -I../../.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o mail_screen.o mail_screen.cc
mail_screen.cc: In function ‘void init_main_screen()’:
mail_screen.cc:39:16: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
39 | maxx = stdscr->_maxx;
| ^~
In file included from mail_screen.cc:13:
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka ‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
| ^~~~~~~
mail_screen.cc:40:16: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
40 | maxy = stdscr->_maxy;
| ^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka ‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
| ^~~~~~~
mail_screen.cc: In function ‘void redraw()’:
mail_screen.cc:70:15: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
70 | main_window->_clear = TRUE;
| ^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka ‘struct _win_st’}
442 | typedef struct _win_st WINDOW;
The attached patch, which can be added to the series file fixes, these
errors and two additional ones in src/linpac.cc, but I have only tested
that the package builds, not if it works. Note that getmaxx(win)
returns win->_maxx + 1, and similar for getmaxy.
Cheers,
Sven
|