Hello,
On Sat, Mar 04, 2023 at 05:20:44PM +0000, Dave Hibberd wrote:
> Hi there Mike,
>
> Thanks for this patch.
>
> I have built it on my devbox and it compiles fine. I’ve not tested it as I don’t have the means to at the moment!
>
> I shall look at committing this properly when I’m reunited with my yubikey unless someone else wants to do it first
>
> Cheers
> H
>
>
> > On 2 Mar 2023, at 17:12, Mike Quin <mike@elite.uk.com> wrote:
> >
> > Revised 05-fix-compile-warnings patch attached.
> >
> > —
> > Mike Quin
> > <05-fix-compile-warnings>
I'm not familiar with fbb enough to claim to do adequate testing, but
the delta in the patch looks technically correct. The original
src/ibm.c contains the lstat() and stat() calls in those locations; the
only difference is that it stores their return value in an unused
variable.
So I think their deletion in the prior patch was inadvertent and the
patch is good. I can commit and upload if that's helpful.
Cheers,
tony
$ interdiff -p1 debian/patches/05-fix-compile-warnings /tmp/05-fix-compile-warnings
diff -u b/src/ibm.c fbb-7.011/src/ibm.c
--- b/src/ibm.c
+++ fbb-7.011/src/ibm.c
@@ -204,10 +204,13 @@
else
sprintf (filename, "%s/%s", blk->ff_base, dir->d_name);
+ lstat (filename, &st);
+
if (S_ISLNK (st.st_mode))
{
/* printf ("link\n"); */
blk->ff_attrib |= FA_LINK;
+ stat (filename, &st);
if (S_ISDIR (st.st_mode))
{
blk->ff_attrib |= FA_DIREC;
Attachment:
signature.asc
Description: PGP signature