[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1059751: marked as done (xnec2c FTCBFS: uses the build architecture pkg-config)



Your message dated Sun, 31 Dec 2023 19:36:29 +0000
with message-id <E1rK1bp-005G8j-8J@fasolo.debian.org>
and subject line Bug#1059751: fixed in xnec2c 1:4.4.12-2
has caused the Debian Bug report #1059751,
regarding xnec2c FTCBFS: uses the build architecture pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1059751: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059751
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: xnec2c
Version: 1:4.4.12-1
Tags: patch upstream
User: debian-cross@lists.debian.org
Usertags: ftcbfs

xnec2c fails to cross build from source, because it hard codes the build
architecture pkg-config in src/Makefile.am. As a consequence, it fails
to locate glib-compile-resources and then things go bad. Running
pkg-config should only be done at configure time and preferrably using
PKG_CHECK_MODULES or something similar. Then the result of that should
be substituted into the generated Makefiles. I'm attaching a patch for
your convenience.

Helmut
--- xnec2c-4.4.12.orig/configure.ac
+++ xnec2c-4.4.12/configure.ac
@@ -29,6 +29,10 @@
 AC_SUBST(PACKAGE_CFLAGS)
 AC_SUBST(PACKAGE_LIBS)
 
+PKG_CHECK_MODULES(GIO, [gio-2.0])
+GLIB_COMPILE_RESOURCES=`$PKG_CONFIG --variable glib_compile_resources gio-2.0`
+AC_SUBST([GLIB_COMPILE_RESOURCES])
+
 # GCC has atan2 as a built-in so the autoconf test casts it incorrectly and triggers a warning.
 # This causes -Werror to fail and then xnec2c does not link with -lm.  Disable built-ins
 # for this test:
--- xnec2c-4.4.12.orig/src/Makefile.am
+++ xnec2c-4.4.12/src/Makefile.am
@@ -55,8 +55,5 @@
 
 xnec2c_LDADD = @PACKAGE_LIBS@ $(INTLLIBS)
 
-PKGCONFIG = $(shell which pkg-config)
-GLIB_COMPILE_RESOURCES = $(shell $(PKGCONFIG) --variable=glib_compile_resources gio-2.0)
-
 xnec2c-resources.c: ../resources/xnec2c.gresource.xml $(shell $(GLIB_COMPILE_RESOURCES) --sourcedir=../resources --generate-dependencies ../resources/xnec2c.gresource.xml)
 	$(GLIB_COMPILE_RESOURCES) --sourcedir=../resources --target=xnec2c-resources.c --generate-source ../resources/xnec2c.gresource.xml

--- End Message ---
--- Begin Message ---
Source: xnec2c
Source-Version: 1:4.4.12-2
Done: tony mancill <tmancill@debian.org>

We believe that the bug you reported is fixed in the latest version of
xnec2c, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059751@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
tony mancill <tmancill@debian.org> (supplier of updated xnec2c package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 31 Dec 2023 11:16:35 -0800
Source: xnec2c
Architecture: source
Version: 1:4.4.12-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: tony mancill <tmancill@debian.org>
Closes: 1059751
Changes:
 xnec2c (1:4.4.12-2) unstable; urgency=medium
 .
   * Team upload.
   * Add patch for FTCBFS (Closes: #1059751)
     Thank you to Helmut Grohne <helmut@subdivi.de> for the patch.
   * Bump Standards-Version to 4.6.2
   * Freshen years in debian/copyright
Checksums-Sha1:
 235de3d6ee9417c3afab616aeacc0d61201c4eb4 1963 xnec2c_4.4.12-2.dsc
 eeb8ec5730abacf43fb6f2d12735204245934677 5924 xnec2c_4.4.12-2.debian.tar.xz
 5fadcc52927ad1e1c5e9d18834e5606289c51a11 15136 xnec2c_4.4.12-2_amd64.buildinfo
Checksums-Sha256:
 09478c71496311614865a7723ccc92f0df44b12845ca1008b3f01881e235c193 1963 xnec2c_4.4.12-2.dsc
 cc23a2592bc2888d2eefd0fe032be3d35951c8bf560a432e4059ae465a448a0f 5924 xnec2c_4.4.12-2.debian.tar.xz
 53c398966674537f9a39ef1744106a52671b6cc896f4ae818a0896c45a880f55 15136 xnec2c_4.4.12-2_amd64.buildinfo
Files:
 5632cc76cebe3afdf2c155239de56016 1963 hamradio optional xnec2c_4.4.12-2.dsc
 5d10583b1a8715296185efaeb30af6e7 5924 hamradio optional xnec2c_4.4.12-2.debian.tar.xz
 486a49f9ee2836196ca475bafe6775ca 15136 hamradio optional xnec2c_4.4.12-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmWRv0wUHHRtYW5jaWxs
QGRlYmlhbi5vcmcACgkQIdIFiZdLPpa4nBAAw4f2F+ls73nM+a1FdW2UWGAf8/Zi
CjHpD6EWGYquhKoznYhhfa1KavqPaHDli8NO8/yxq5biZqE+y+rF4x1iIyH1l8VY
+q8m1Xu1jt4zZEoRfAKXQaYLUTkjSbF9faCdHoPzwLrCa4BevKjIEdtF8EqJxsPG
tq2czLSaMnzkrQ7xaHHQyCpwxhuJe++7AqXQ4DClk93ucAcHPsV7yjStSUxPL6ro
lwJgEtgfMQfMlukGEP024VFt+wiOxfd/RIdxrcgzsyM0wYBUZJA4qUWXhxKk2Gbf
d8SyptRK2pCoZfhwlUM2rZQwNEd3A3JVDjzU/aaVvoDk6QKYcCWXM4xrFrpHqtsh
but6z3HBgmhwO8dfQFkAgOclmXNYSzJFUhHdg80J65yD0E36TaNhDeUXRhHiovO7
rvPdEogfXEpCNVt6bbIBqU2W3YqMhRD3ABG7p1+/MwGmZNXiRVBl8qHU9mDkHJo8
sSjVU1rS2YU6gjIxcH8gg60cOiGSDXQC69moExTcHuqO5uaOyQNf7zNOVJVfGjKj
YBANxJ5Bn11OWNTGoKX9gGuSG0/YCobl5GlHwPGNQyj8Sdz1xP5ao6zm3/r06MDi
f8BCJ9PLkQELJs3TWTVo03Tx35qs5Fn2vocXILU6SJqiQXx9lp1Eu/FNSBZloKJA
Ou9TpVb17o0fHq0=
=gD5n
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: