Bug#1057573: linpac: FTBFS: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}

[David Ranch <dranch@trinnet.net>]

Hello Sven, Debian team,

I was about to apply a very similar fix to the "develop" branch of Linpac at https://sourceforge.net/p/linpac/linpac/ci/develop/tree though my changes didn't include the "-1" at the end of the changes.  Not sure if that's needed / important.  Regardless, I am planning to eventually merge the develop branch into the Master branch and releae 0.29 in the near future which will include this and other fixes.

--David
KI6ZHD

On 12/16/2023 10:01 AM, Sven Joachim wrote:

Control: tags -1 + patch

On 2023-12-05 23:07 +0100, Santiago Vila wrote:

Package: src:linpac
Version: 0.28-2
Severity: serious
Tags: ftbfs

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

--------------------------------------------------------------------------------
[...]
g++ -DHAVE_CONFIG_H -I. -I../../..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o mail_screen.o mail_screen.cc
mail_screen.cc: In function ‘void init_main_screen()’:
mail_screen.cc:39:16: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
   39 |   maxx = stdscr->_maxx;
      |                ^~
In file included from mail_screen.cc:13:
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka ‘struct _win_st’}
  442 | typedef struct _win_st WINDOW;
      |                ^~~~~~~
mail_screen.cc:40:16: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
   40 |   maxy = stdscr->_maxy;
      |                ^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka ‘struct _win_st’}
  442 | typedef struct _win_st WINDOW;
      |                ^~~~~~~
mail_screen.cc: In function ‘void redraw()’:
mail_screen.cc:70:15: error: invalid use of incomplete type ‘WINDOW’ {aka ‘struct _win_st’}
   70 |    main_window->_clear = TRUE;
      |               ^~
/usr/include/curses.h:442:16: note: forward declaration of ‘WINDOW’ {aka ‘struct _win_st’}
  442 | typedef struct _win_st WINDOW;

The attached patch, which can be added to the series file fixes, these
errors and two additional ones in src/linpac.cc, but I have only tested
that the package builds, not if it works.  Note that getmaxx(win)
returns win->_maxx + 1, and similar for getmaxy.

Cheers,
       Sven