[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#993698: marked as done (hacktv: FTBFS with libsoapysdr 0.8)



Your message dated Wed, 15 Sep 2021 13:49:16 +0000
with message-id <E1mQVHo-00092f-1Y@fasolo.debian.org>
and subject line Bug#993698: fixed in hacktv 0+git20210914-1
has caused the Debian Bug report #993698,
regarding hacktv: FTBFS with libsoapysdr 0.8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
993698: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=993698
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: hacktv
Version: 0+git20201203-1
Severity: important
Tags: ftbfs upstream upstream

I am building rdeps of libsoapysdr in preparation of the transition to
version 0.8. This version has changed the SoapySDRDevice_setupStream()
function signature to return the SoapySDRStream directly rather than
through a pointer:

    *   Recommended keys to use in the args dictionary:
    *    - "WIRE" - format of the samples between device and host
    * \endparblock
  - * \return 0 for success or error code on failure
  + * \return the stream pointer or nullptr for failure
    */
  -SOAPY_SDR_API int SoapySDRDevice_setupStream(SoapySDRDevice *device,
  -    SoapySDRStream **stream,
  +SOAPY_SDR_API SoapySDRStream *SoapySDRDevice_setupStream(SoapySDRDevice *device,
       const int direction,
       const char *format,
       const size_t *channels,

This causes a build failure in hacktv when building against the new
libsoapysdr. Upstream does not appear to have a fix yet, one way would
be using preprocessor directives to discriminate between API version
using SOAPY_SDR_API_VERSION.

Log of the failed build:

soapysdr.c: In function 'rf_soapysdr_open':
soapysdr.c:135:39: warning: passing argument 2 of 'SoapySDRDevice_setupStream' makes integer from pointer without a cast [-Wint-conversion]
  135 |  if(SoapySDRDevice_setupStream(rf->d, &rf->s, SOAPY_SDR_TX, SOAPY_SDR_CS16, NULL, 0, NULL) != 0)
      |                                       ^~~~~~
      |                                       |
      |                                       SoapySDRStream **
In file included from soapysdr.c:20:
/usr/include/SoapySDR/Device.h:307:15: note: expected 'int' but argument is of type 'SoapySDRStream **'
  307 |     const int direction,
      |     ~~~~~~~~~~^~~~~~~~~
soapysdr.c:135:61: warning: passing argument 4 of 'SoapySDRDevice_setupStream' from incompatible pointer type [-Wincompatible-pointer-types]
  135 |  if(SoapySDRDevice_setupStream(rf->d, &rf->s, SOAPY_SDR_TX, SOAPY_SDR_CS16, NULL, 0, NULL) != 0)
      |                                                             ^~~~~~~~~~~~~~
      |                                                             |
      |                                                             char *
In file included from soapysdr.c:20:
/usr/include/SoapySDR/Device.h:309:19: note: expected 'const size_t *' {aka 'const long unsigned int *'} but argument is of type 'char *'
  309 |     const size_t *channels,
      |     ~~~~~~~~~~~~~~^~~~~~~~
soapysdr.c:135:77: warning: passing argument 5 of 'SoapySDRDevice_setupStream' makes integer from pointer without a cast [-Wint-conversion]
  135 |  if(SoapySDRDevice_setupStream(rf->d, &rf->s, SOAPY_SDR_TX, SOAPY_SDR_CS16, NULL, 0, NULL) != 0)
      |                                                                             ^~~~
      |                                                                             |
      |                                                                             void *
In file included from soapysdr.c:20:
/usr/include/SoapySDR/Device.h:310:18: note: expected 'size_t' {aka 'const long unsigned int'} but argument is of type 'void *'
  310 |     const size_t numChans,
      |     ~~~~~~~~~~~~~^~~~~~~~
soapysdr.c:135:5: error: too many arguments to function 'SoapySDRDevice_setupStream'
  135 |  if(SoapySDRDevice_setupStream(rf->d, &rf->s, SOAPY_SDR_TX, SOAPY_SDR_CS16, NULL, 0, NULL) != 0)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from soapysdr.c:20:
/usr/include/SoapySDR/Device.h:306:31: note: declared here
  306 | SOAPY_SDR_API SoapySDRStream *SoapySDRDevice_setupStream(SoapySDRDevice *device,
      |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~

--- End Message ---
--- Begin Message ---
Source: hacktv
Source-Version: 0+git20210914-1
Done: Gürkan Myczko <gurkan@phys.ethz.ch>

We believe that the bug you reported is fixed in the latest version of
hacktv, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 993698@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gürkan Myczko <gurkan@phys.ethz.ch> (supplier of updated hacktv package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 14 Sep 2021 08:53:02 +0200
Source: hacktv
Architecture: source
Version: 0+git20210914-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Gürkan Myczko <gurkan@phys.ethz.ch>
Closes: 993698
Changes:
 hacktv (0+git20210914-1) unstable; urgency=medium
 .
   * New upstream version. (Closes: #993698)
Checksums-Sha1:
 8ab2c4973df75f63e356b725d3d0c2af1d60e85d 2138 hacktv_0+git20210914-1.dsc
 927151b32688ac7ed8905ad47c7f118e32866926 254813 hacktv_0+git20210914.orig.tar.gz
 a11b32dad229e4a5c7ec07483f66e0eb7dcd8d64 4944 hacktv_0+git20210914-1.debian.tar.xz
 5e38191f2438ea7e871200d0d62165eaa4d1eeca 11166 hacktv_0+git20210914-1_source.buildinfo
Checksums-Sha256:
 5e7ce4e966d635b574be6b79d72211824adcfd3f6404628a6f9a57007cdea7e0 2138 hacktv_0+git20210914-1.dsc
 ddd4c116b4dd54f56ff828304444222879a20e769b00104c3eaf980cd1d76787 254813 hacktv_0+git20210914.orig.tar.gz
 d1a01096c5a6af9736de09759f5c06fa34532317401a40154cf063540325ca3f 4944 hacktv_0+git20210914-1.debian.tar.xz
 941f5fcc766838c9f257104fbc1cfca8a7f827aee7efc99bf877c20617314b0a 11166 hacktv_0+git20210914-1_source.buildinfo
Files:
 5a4d404130d729b98a0948044a5a3e65 2138 hamradio optional hacktv_0+git20210914-1.dsc
 08eba695e525efebe6f7f73d4b976fb5 254813 hamradio optional hacktv_0+git20210914.orig.tar.gz
 a29f10b8c17f22f984ffe9dee36074e0 4944 hamradio optional hacktv_0+git20210914-1.debian.tar.xz
 4f182148d5ed4ec2dd672baad8aacf50 11166 hamradio optional hacktv_0+git20210914-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAmFB9j4ACgkQweDZLphv
fH5Ucw/+MG/Pe/ApJDFunJLMY2Ohtt2YE4HJArDwsIiNpGd36N4WaVvoQJ/0PssO
A+9C7eXhJFegTKn1qi1WcFxdr8tLKug1VngrzpWJcAvBpeKvc49WYYYAsY3FDuGV
Kgi++rgHOHwcT4+L0poa2u7EajRLQuEER+KNRZ8PvSIUfoCANxq4qhmj8yetaXI4
5aobwJIFGQNDHvFxdmGIfzViqUlMHTy3KbwPi4engcU5857Qd7O60JeG44eN9Iel
Owa8OajbblUtQ+3uDoQY81yVwYiHtgG8M186ySf5gotu6Jc7N8Yoi6B9lma7HhQJ
85VidqXQiis3X9LDUGahFbkufqc8T5za7xpmjNRDXq9X4RGd2RcN2ztKo3dIi7Dv
A6MsmrzJ9O9L8bQSmxyKo6wsaFRP5Ws/fzSHHVxQujVH9IeqXv6WmeYK94GvUNlD
pj7xq71kww51oJh2WZO1lDxTFQGRCFa+/HnvqIDIMS7CyQQWzfCsFJcAAdvV0FBR
y+wl/ooJub5d/UCTJuxMqNpmC5vqvd3XfdRN9JENCmvMh/UKB38uwDOf45Bfn880
y+QamCNwogmDEUrtw7tvXKe48ZKWl7HtO+NetuG364h0VHF34txGVVtlqi6qmJ9l
5N/Y3uhvnPcP5EZXcrc5Uml9owRSzPRtEUrcN2o98fwQ6XhfvfY=
=1r3+
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: