[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#985812: marked as done (libax25: long serial device symlinks break kissattach (in libax25))

Your message dated Tue, 14 Sep 2021 15:05:05 +0000
with message-id <E1mQ9zd-00063H-Qi@fasolo.debian.org>
and subject line Bug#985812: fixed in libax25 0.0.12-rc5+git20190411+b17ff36-4
has caused the Debian Bug report #985812,
regarding libax25: long serial device symlinks break kissattach (in libax25)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
985812: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985812
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libax25
Version: 0.0.12-rc5+git20190411+b17ff36-3.1
Severity: important
Tags: patch

Dear Maintainer,

I ran into a problem with kissattach, but the buffer overflow was
actually happening in libax25:

(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x76e69230 in __GI_abort () at abort.c:79
#2  0x76eb951c in __libc_message (action=<optimized out>, fmt=<optimized out>)
 at ../sysdeps/posix/libc_fatal.c:181
#3  0x76f3b6fc in __GI___fortify_fail_abort (need_backtrace=need_backtrace@entry=true,
 msg=0x76f824d8 "buffer overflow detected") at fortify_fail.c:28
#4  0x76f3b748 in __GI___fortify_fail (msg=<optimized out>) at fortify_fail.c:44
#5  0x76f395c8 in __GI___chk_fail () at chk_fail.c:28
#6  0x76f38a60 in _IO_str_chk_overflow (fp=<optimized out>, c=<optimized out>) at vsprintf_chk.c:31
#7  0x76ebdd04 in __GI__IO_default_xsputn (n=<optimized out>, data=<optimized out>, f=<optimized out>)
 at libioP.h:839
#8  __GI__IO_default_xsputn (f=0x7efff400, data=<optimized out>, n=55) at genops.c:370
#9  0x76e93800 in _IO_vfprintf_internal (s=s@entry=0x7efff400, format=format@entry=0x76fa7180
+"%s/LCK..%s",
 ap=..., ap@entry=...) at ../libio/libioP.h:839
#10 0x76f38b00 in ___vsprintf_chk (s=s@entry=0x7efff500
+"/var/lock/LCK..usb-Coastal_ChipWorks_TNC-X_by_W2F",
 flags=flags@entry=1, slen=slen@entry=50, format=0x76fa7180 "%s/LCK..%s",
 format@entry=0xf571100 <error: Cannot access memory at address 0xf571100>, args=..., args@entry=...)
 at vsprintf_chk.c:83
#11 0x76f38a2c in ___sprintf_chk (s=s@entry=0x7efff500
+"/var/lock/LCK..usb-Coastal_ChipWorks_TNC-X_by_W2F",
 flags=flags@entry=1, slen=slen@entry=50, format=0x76fa7180 "%s/LCK..%s") at sprintf_chk.c:31
#12 0x76fa672c in sprintf (__fmt=0x76fa7180 "%s/LCK..%s",
 __s=0x7efff500 "/var/lock/LCK..usb-Coastal_ChipWorks_TNC-X_by_W2F")
 at /usr/include/arm-linux-gnueabihf/bits/stdio2.h:36
#13 tty_is_locked (
 tty=tty@entry=0x7efff882 "/dev/serial/by-id/usb-Coastal_ChipWorks_TNC-X_by_W2FS_FT3PPKKT-if00-port0")
 at ttyutils.c:112
#14 0x000112b8 in main (argc=3, argv=<optimized out>) at kissattach.c:294

ran into it in raspbian, debian buster, and in the latest package in testing...
Upstream has fixed it here: http://git.linux-ax25.org/cgit/libax25.git/patch/?id=f7e4a620aaa061bca62c2cef7dd508157e482c68

I added the patch locally and tested the fix here, and it seems to work.

-- System Information:
Debian Release: 10.8
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-14-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libax25 depends on:
ii  libc6   2.28-10
ii  zlib1g  1:1.2.11.dfsg-1

libax25 recommends no packages.

libax25 suggests no packages.

-- Configuration Files:
/etc/ax25/axports changed:
1	K6FSM-5		1200	255	2	2m radio


-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: libax25
Source-Version: 0.0.12-rc5+git20190411+b17ff36-4
Done: Dave Hibberd <d@vehibberd.com>

We believe that the bug you reported is fixed in the latest version of
libax25, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 985812@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dave Hibberd <d@vehibberd.com> (supplier of updated libax25 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 13 Sep 2021 23:53:50 +0100
Source: libax25
Architecture: source
Version: 0.0.12-rc5+git20190411+b17ff36-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Dave Hibberd <d@vehibberd.com>
Closes: 985812 990596
Changes:
 libax25 (0.0.12-rc5+git20190411+b17ff36-4) unstable; urgency=medium
 .
   * Remove colint from Uploaders, thanks for all your work!
     - Closes: #990596
   * Bump dh to 13
   * Bump standards to 4.6.0.0
   * Added Gitlab CI
   * Added Upstream patch for long serial device symlinks
     - Closes: #985812
   * Added Rules-Requires-Root:no to d/control
Checksums-Sha1:
 d263aae8fe231d17b3d645613e6cba4753e5fd16 1813 libax25_0.0.12-rc5+git20190411+b17ff36-4.dsc
 e6c97418ea37b1aaacc124ed4bf38858b342b27a 6356 libax25_0.0.12-rc5+git20190411+b17ff36-4.debian.tar.xz
 cea76bfb04d27f332da5bb62b9efcbeae328ed89 6249 libax25_0.0.12-rc5+git20190411+b17ff36-4_amd64.buildinfo
Checksums-Sha256:
 3ecdbf1bfb2805656253e8276ab9469f7a92a1d06fc34948cd0854bf2bf64852 1813 libax25_0.0.12-rc5+git20190411+b17ff36-4.dsc
 9582194fdc85340a63bf66f7bb5e958be83ce728ab0994daa729ec76c75876ac 6356 libax25_0.0.12-rc5+git20190411+b17ff36-4.debian.tar.xz
 9bf717d9bf0982dca61e37648d2906834da1391d336edd860000b3c2b1903666 6249 libax25_0.0.12-rc5+git20190411+b17ff36-4_amd64.buildinfo
Files:
 0ae49f60b76a19d417e0e7a055a81f1d 1813 hamradio optional libax25_0.0.12-rc5+git20190411+b17ff36-4.dsc
 b3e7e6020ada3eae10e6918827019bdf 6356 hamradio optional libax25_0.0.12-rc5+git20190411+b17ff36-4.debian.tar.xz
 2f4efcfd6368d2018c28dca6d309e79d 6249 hamradio optional libax25_0.0.12-rc5+git20190411+b17ff36-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEERzSH56pa+zBfre1AiVnjPMqARLoFAmFAsFgACgkQiVnjPMqA
RLphhwf+PP1uUTgUL6bAO1VUrAyGX4nSKNGhIp4HnVETmc24SwRZo5C1Jvucgm0a
wuLqcb4nRygtq8mHmHNuTkK19wG2nybR8DqUhdyhfWEHPLztCz60MeGhZpKor9hH
nrl7vJwnHna2lHEAvbLaCJcTt4uwfkQB7hqBzn7DXU57njM35YpqfjAYU4asLcbR
ZmPxRsBP3TooAF9gvwCUywUd5NT3sN4danIDs1Xok5VbAiu/VkPQ/y07ySQLq8z9
6/GsOfMFlj1TJzRGErIEgnIcCdO/2o3SXuqQhcUEMIadbsapGrE0hFVhySpzmtbh
rksHeglk0OB1uNY2lFPphMBTX2x/UQ==
=0ujK
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: