[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#980472: cubicsdr: CubicSDR crashes after lauch! (same effect on 2 clean bullseye OS)



On Tue, Jun 01, 2021 at 02:06:33AM +0300, Adrian Bunk wrote:
> Control: reassign -1 libhamlib4 4.0-6
> Control: fixed -1 4.1-1
> Control: affects -1 cubicsdr
> Control: forwarded -1 https://sourceforge.net/p/hamlib/code/ci/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0/
> 
> The oneline fix for hamlib above matches your analysis exactly.

And indeed it does!  Thank you for the pointer Adrian.

I was able to reproduce the crash with cubicsdr locally using a basic
RTL2832U dongle.  Then I built and tested with the reference patch and
cubicsdr is working for me.  I also did a very quick check of wsjtx.

Any concerns with an upload to unstable, hopefully in time a last-second
unblock request for bullseye?  (debdiff attached)

Cheers,
tony
diff -Nru hamlib-4.0/debian/changelog hamlib-4.0/debian/changelog
--- hamlib-4.0/debian/changelog	2021-05-11 10:03:12.000000000 -0700
+++ hamlib-4.0/debian/changelog	2021-07-15 21:31:14.000000000 -0700
@@ -1,3 +1,11 @@
+hamlib (4.0-7) unstable; urgency=medium
+
+  * Team upload.
+  * Allow rig_load_all_backends to be called more than once.
+    (Closes: #980472)
+
+ -- tony mancill <tmancill@debian.org>  Thu, 15 Jul 2021 21:31:14 -0700
+
 hamlib (4.0-6) unstable; urgency=medium
 
   * Paper over a minor precision difference in dec2dms on i386.
diff -Nru hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0 hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0
--- hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0	1969-12-31 16:00:00.000000000 -0800
+++ hamlib-4.0/debian/patches/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0	2021-07-15 21:31:14.000000000 -0700
@@ -0,0 +1,17 @@
+Comment: Allow rig_load_all_backends to be called more than once
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980472
+Forwarded: not-needed
+Source: https://sourceforge.net/p/hamlib/code/ci/31dedcf4f79d8fc5fcf287360e5d017842c8e4c0/
+Author: Michael Black W9MDB
+
+--- a/src/register.c
++++ b/src/register.c
+@@ -454,6 +454,8 @@
+ {
+     int i;
+ 
++    memset(rig_hash_table, 0 , sizeof(rig_hash_table));
++
+     for (i = 0; i < RIG_BACKEND_MAX && rig_backend_list[i].be_name; i++)
+     {
+         rig_load_backend(rig_backend_list[i].be_name);
diff -Nru hamlib-4.0/debian/patches/series hamlib-4.0/debian/patches/series
--- hamlib-4.0/debian/patches/series	2021-05-11 10:03:12.000000000 -0700
+++ hamlib-4.0/debian/patches/series	2021-07-15 21:31:14.000000000 -0700
@@ -7,3 +7,4 @@
 cf858bfa3c8a36eda749c5078ef6f53a119fb285
 0089964af7fa1f43757083b7bc7db195ba382fe0
 1d74711a00dfa416a171cec87c841db315c5d9f7
+31dedcf4f79d8fc5fcf287360e5d017842c8e4c0

Attachment: signature.asc
Description: PGP signature


Reply to: