On Sun, 25 Apr 2021, Evgeni Golov wrote:
On Sun, Apr 25, 2021 at 03:41:38PM +0300, Heikki Hannikainen wrote:This would be very important to make this happen. Shipping a config with the "mycall N0CALL-1" line commented out would probably work.If we change the default config, but let the service enabled, it will fail to start (which is *technically* what you want, as it will prevent wrongly configured installations from connecting to you). At the same time, everyone who updates from Buster to Bullseye (and has the bad old config) will face a failed upgrade and has to search why it failed, what they have to fix and then restart the upgrade.
Right, a failed upgrade would not be good.
We're not breaking a working service with this approach, but it also feels weird towards the user (even if we can question why they have aprx installed, when it's not properly configured -- or is there any use without the daemon running correctly?).
There is no use of the daemon when it is running with its default config. It doesn't do anything useful, it just connects to the server and sits there. To make it useful, the config needs to be updated with a correct callsign, some configuration to attach it to a radio interface, and possibly beaconing config.
I think it should be possible to detect the "N0CALL" configurations on upgrade and disable the service, thus reaching the same state as with my above change for new installs.
Right, something like a grep for the bad "^mycall\s+N0CALL-1" would be a suitable trigger.
- Hessu