--- Begin Message ---
Source: dump1090-mutability
Version: 1.15~20180310.4a16df3+dfsg-6
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch
Hi,
dump1090-mutability FTBFS with GCC 10. [1] This is due to multiple
defintions of a variable (GCC 10 enables -fno-common by default).
In Ubuntu, the attached patch was applied to achieve the following:
* d/p/05-gcc-10.patch: Cherrypick upstream Git commit to fix FTBFS with GCC
10.
Thanks for considering the patch.
Logan
[1] https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/dump1090-mutability.html
diff -Nru dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/05-gcc-10.patch dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/05-gcc-10.patch
--- dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/05-gcc-10.patch 1969-12-31 19:00:00.000000000 -0500
+++ dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/05-gcc-10.patch 2021-01-19 22:36:11.000000000 -0500
@@ -0,0 +1,72 @@
+From 0793c64ee8ebbcea86b7a9dc71c7e28ec08db618 Mon Sep 17 00:00:00 2001
+From: Oliver Jowett <oliver.jowett@flightaware.com>
+Date: Sat, 6 Jun 2020 21:52:04 +0800
+Subject: [PATCH] Clean up linkage of struct Modes to actually make sense.
+
+(how did this work before? But it's been unchanged since at least
+2013..)
+
+Maybe fixes #65
+---
+ dump1090.c | 2 ++
+ dump1090.h | 6 ++++--
+ faup1090.c | 2 ++
+ view1090.c | 3 +++
+ 4 files changed, 11 insertions(+), 2 deletions(-)
+
+--- a/dump1090.c
++++ b/dump1090.c
+@@ -55,6 +55,8 @@
+
+ static int verbose_device_search(char *s);
+
++struct _Modes Modes;
++
+ //
+ // ============================= Utility functions ==========================
+ //
+--- a/dump1090.h
++++ b/dump1090.h
+@@ -263,7 +263,7 @@
+ };
+
+ // Program global state
+-struct { // Internal state
++struct _Modes { // Internal state
+ pthread_t reader_thread;
+
+ pthread_mutex_t data_mutex; // Mutex to synchronize buffer access
+@@ -378,7 +378,9 @@
+ int stats_latest_1min;
+ struct stats stats_5min;
+ struct stats stats_15min;
+-} Modes;
++};
++
++extern struct _Modes Modes;
+
+ // The struct we use to store information about a decoded message.
+ struct modesMessage {
+--- a/faup1090.c
++++ b/faup1090.c
+@@ -49,6 +49,8 @@
+
+ #include "dump1090.h"
+
++struct _Modes Modes;
++
+ #include <stdarg.h>
+
+ //
+--- a/view1090.c
++++ b/view1090.c
+@@ -28,6 +28,9 @@
+ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ //
+ #include "dump1090.h"
++
++struct _Modes Modes;
++
+ //
+ // ============================= Utility functions ==========================
+ //
diff -Nru dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/series dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/series
--- dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/series 2018-12-21 04:34:58.000000000 -0500
+++ dump1090-mutability-1.15~20180310.4a16df3+dfsg/debian/patches/series 2021-01-19 22:36:06.000000000 -0500
@@ -2,3 +2,4 @@
02-excanvas.patch
03-gcc7.patch
04-link-order.patch
+05-gcc-10.patch
--- End Message ---
--- Begin Message ---
Source: dump1090-mutability
Source-Version: 1.15~20180310.4a16df3+dfsg-7
Done: tony mancill <tmancill@debian.org>
We believe that the bug you reported is fixed in the latest version of
dump1090-mutability, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 980515@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
tony mancill <tmancill@debian.org> (supplier of updated dump1090-mutability package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 23 Jan 2021 09:11:16 -0800
Source: dump1090-mutability
Architecture: source
Version: 1.15~20180310.4a16df3+dfsg-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: tony mancill <tmancill@debian.org>
Closes: 980515
Changes:
dump1090-mutability (1.15~20180310.4a16df3+dfsg-7) unstable; urgency=medium
.
* Team upload.
.
[ Gürkan Myczko ]
* Add README.Debian
.
[ Matteo F. Vescovi ]
* debian/control: drop myself from Uploaders
.
[ tony mancill ]
* Add patch for FTBFS with GCC 10 (Closes: #980515)
* Set Rules-Requires-Root: no in debian/control
* Bump Standards-Version to 4.5.1
* Use debhelper-compat 13
Checksums-Sha1:
a1c9df33cde88ffa4028048bba3c33e9d0ab3edd 2309 dump1090-mutability_1.15~20180310.4a16df3+dfsg-7.dsc
a3e4ec881fea50c2f333f09770f66a74cf9502ec 33136 dump1090-mutability_1.15~20180310.4a16df3+dfsg-7.debian.tar.xz
4ef35c67f96c851b857de15080bf71a895a8d657 7502 dump1090-mutability_1.15~20180310.4a16df3+dfsg-7_amd64.buildinfo
Checksums-Sha256:
273c4a309a9c1bbcf194b515915c5d3af22631d6cf3b6debd6c480a6bb8dd806 2309 dump1090-mutability_1.15~20180310.4a16df3+dfsg-7.dsc
281f148903902dcfe6ed8472956cf2afe9076801a0433a24c8929e90eeaa9f30 33136 dump1090-mutability_1.15~20180310.4a16df3+dfsg-7.debian.tar.xz
e9429f7f4ef6eb381b1c64d988b040b26f090a565e65c6669ff061cc35a71152 7502 dump1090-mutability_1.15~20180310.4a16df3+dfsg-7_amd64.buildinfo
Files:
c6e991c3ee758cc544f32309247fce6b 2309 net optional dump1090-mutability_1.15~20180310.4a16df3+dfsg-7.dsc
e56c088ca0d31f975c9f790c5e1b50a9 33136 net optional dump1090-mutability_1.15~20180310.4a16df3+dfsg-7.debian.tar.xz
94f6a121f9dcb09a942d7a82a6f04cbc 7502 net optional dump1090-mutability_1.15~20180310.4a16df3+dfsg-7_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJIBAEBCgAyFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmAMWaEUHHRtYW5jaWxs
QGRlYmlhbi5vcmcACgkQIdIFiZdLPpZfGQ/+PPftcjPgGyMFHSKzP1QZSEpvNXLz
bfi0XM2FB74TFLrkzR4CiBDXPNA/G+88LbCD5kT3lMt6KjKuOIdGC4VZpai3Z5wN
wz6xXe/Du9tn/ZvF/nq7gitadSU2rSqSUdPEVQLP73ynA+qr5AWt7JHfidKgLE/T
G/ka4w99OOLl3yIHptnwFQj7rt1X4yqacYL02fPBWAu4kK1jhtJSelHw9hPAeums
y9cbNGIQsAff4dInaGu1zDJkhjZrf2zmBIRrqimTnRSnBWe4giB00a4HrG3L5yiw
vUPGYnGIPysq25hqMnxAYLM6QAGQ+wzjXKJGURF+qv0sMPn6MruoFoD3wXFuLVVn
LF64upzQe5jzms9RlhI7Bff10JMByq4Vubi5Np0qcdi1etxd5Hbrw822PHgirQbR
mpYlAx5KMSeGJNVWenc/FThqPuSXP8cLgwEoS8ftUXThBqZqSpkSS/mwH9cMJ5Q7
nMPZtkB8XGQGfwQ6jm9VmXMjA5/OZJPhVfQWbdvfaXijl+yFepZjP2vUGsXQSDOE
DifDXAnWBslwr2etwTHu/qWEBo9PBzVUqtw8ZXs4Efy9YbvbkH3Tutx6OTx4i1PN
2R9r9VW5bYkdXQp4EDGZvKaL2IEaWO1GN/86+9TNLyO+W419nOFqdF35z2V1oMOu
7AWqLN+0E0nZSMA=
=C/iK
-----END PGP SIGNATURE-----
--- End Message ---