[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#891405: marked as done (gr-gsm: please make the build reproducible)



Your message dated Wed, 21 Mar 2018 09:21:31 +0000
with message-id <E1eyZw3-000C1M-0E@fasolo.debian.org>
and subject line Bug#891405: fixed in gr-gsm 0.41.2-2
has caused the Debian Bug report #891405,
regarding gr-gsm: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
891405: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891405
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: gr-gsm
Version: 0.41.2-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that gr-gsm could not be built reproducibly as it includes a
timestamp in the binary.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
--- a/debian/patches/10001-reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/10001-reproducible-build.patch	2018-02-25 09:54:38.647275238 +0000
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2018-02-25
+
+--- gr-gsm-0.41.2.orig/lib/CMakeLists.txt
++++ gr-gsm-0.41.2/lib/CMakeLists.txt
+@@ -44,7 +44,7 @@ endmacro()
+ # Handle the generated constants
+ ########################################################################
+ execute_process(COMMAND ${PYTHON_EXECUTABLE} -c
+-    "import time;print time.strftime('%a, %d %b %Y %H:%M:%S', time.gmtime())"
++    "import os,time,datetime; print datetime.datetime.utcfromtimestamp(int(os.environ.get('SOURCE_DATE_EPOCH', time.time()))).strftime('%a, %d %b %Y %H:%M:%S')"
+     OUTPUT_VARIABLE BUILD_DATE OUTPUT_STRIP_TRAILING_WHITESPACE
+ )
+ message(STATUS "Loading build date ${BUILD_DATE} into constants...")
--- a/debian/patches/series	2018-02-25 08:41:45.525339428 +0000
--- b/debian/patches/series	2018-02-25 09:54:38.027269791 +0000
@@ -1 +1,2 @@
 1000-desktop-file-location.patch
+10001-reproducible-build.patch

--- End Message ---
--- Begin Message ---
Source: gr-gsm
Source-Version: 0.41.2-2

We believe that the bug you reported is fixed in the latest version of
gr-gsm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 891405@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated gr-gsm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 21 Mar 2018 08:41:10 +0000
Source: gr-gsm
Binary: gr-gsm
Architecture: source
Version: 0.41.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description:
 gr-gsm     - Gnuradio blocks and tools for receiving GSM transmissions
Closes: 891405
Changes:
 gr-gsm (0.41.2-2) unstable; urgency=medium
 .
   * Add doxygen as build dependency to include documentation in package.
   * Added 1010-hackrf-scanner.patch to stop grgsm_scanner from crashing
     with HackRF.
   * Added 1020-reproducible-build.patch to make build timestamp more
     reproducible (Closes: 891405)
   * Update Vcs links to salsa.
   * Changed debhelper compat level from 9 to  10.
   * Remove no longer needed --parallel from d/rules.  Thanks lintian.
Checksums-Sha1:
 d3b59907d19b6e292a0818710b9cba2c2c31b292 2070 gr-gsm_0.41.2-2.dsc
 feaaa39c77c6ed373d924a3fc55d94529d9381fc 4728 gr-gsm_0.41.2-2.debian.tar.xz
 ef1fdc24b1ceb81ed4b34367a8bf4cbae71161b9 16258 gr-gsm_0.41.2-2_source.buildinfo
Checksums-Sha256:
 c6bed9c808be7376bfafcc083f8bcbb145ced3758b1dde726e87e685062ea215 2070 gr-gsm_0.41.2-2.dsc
 5edbf7fbeae1c871cbc5d65e0ee764cb9b85988164ec3652e8507fd8add66b37 4728 gr-gsm_0.41.2-2.debian.tar.xz
 d76bbba7aaba45fd9ec5da91abaf463677efa8bbbcf5c1919777769f1f387704 16258 gr-gsm_0.41.2-2_source.buildinfo
Files:
 27d73bd174a0dd06f0601c054bd3f2da 2070 libdevel optional gr-gsm_0.41.2-2.dsc
 623cf8ee661ea1e4cb559233a6e46665 4728 libdevel optional gr-gsm_0.41.2-2.debian.tar.xz
 dc4eac2bea1894cbc5c553bfc2e62066 16258 libdevel optional gr-gsm_0.41.2-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEERqLf4owIeylOb9kkgSgKoIe6+w4FAlqyG7YACgkQgSgKoIe6
+w7MnhAAqbURhkj+soD0TDl/yStTfMXLz2C9lIm2IJxlmw9Szj8Zr13n1yXXJxVL
IRic27gmKFhHs3vvI3rUfPDpwP1PAqKoU78PhwNgigM7umpydKGWY9/Gdt7Sf6uk
g8cu19r5d8CyepL9Xx4pV+QefBFreSL/5XqMsJ00RBVih4Les4u22japZco0XvG4
EKuOY1XkOLm0NUjB4xouyiwqIlD+IirpebHDOx5g+ZRSh2EiD+gvlhFTupGznnYr
4H8r+hReVN2Y0aXGP24fMN17BRsIf1FFmcZCZ1HjvkJxh4y7uuEtr1+VjJXZLE/j
YLwS6IpkAHI9+sxhAer8h2/5Vmpsh4/+VhDF8g4ZF7FbRZpTyNm3b6Bee3IIHyV8
yRomHxtVeYWWvd/FSp3dIgVmhR7VJD9BujcuyjFH6Ona6c/S6HH7BoosXqPTGkPA
D/6O8pVa1Ucy6nIk+B5TyXdp/MJkNaVFf8xX/TRu3ZebtKi9TTHALkLxlHywFrfN
nxbcoXcOHiErzT+fsa3OrSkAVkqiTfKv6VstnHnLMwnPYOxBIOgggsq8qEwphf24
Fc6Kvn+2lQ00MjVMJZ9EqTDJVuRwHr854QgNxZ2OM7x+vEKROQvm8Y9HexS51U7z
4jyySFUDqgWWrnWjF7lazX1fySKazpMp8C5jDlLjOULYCKpoFQo=
=8cw4
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: