[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888043: marked as done (gpredict FTCBFS: configures for the build architecture, uses the build architecture pkg-config)



Your message dated Mon, 31 Dec 2018 12:20:21 +0000
with message-id <E1gdwYP-0009vp-9j@fasolo.debian.org>
and subject line Bug#888043: fixed in gpredict 2.3-33-gca42d22-1
has caused the Debian Bug report #888043,
regarding gpredict FTCBFS: configures for the build architecture, uses the build architecture pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
888043: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888043
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: gpredict
Version: 2.0-4
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

gpredict fails to cross build from source, because it configures for the
build architecture. It actually configures twice. Once from autogen.sh
and another time from dh_auto_configure. The first invocation tends to
fail for cross compilation though and that aborts the build. Skipping it
makes the build proceed. Then ./configure uses the wrong pkg-config.
Another patch fixes that. After applying both, gpredict cross builds
successfully. Please consider applying them.

Helmut
diff --minimal -Nru gpredict-2.0/debian/changelog gpredict-2.0/debian/changelog
--- gpredict-2.0/debian/changelog	2017-12-28 15:01:00.000000000 +0100
+++ gpredict-2.0/debian/changelog	2018-01-22 21:43:25.000000000 +0100
@@ -1,3 +1,13 @@
+gpredict (2.0-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + 0125-skip-configure.patch: Only run ./configure once and let
+      dh_auto_configure do it.
+    + 0126-cross-pkg-config.patch: Consider $ac_tool_prefix for pkg-config.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 22 Jan 2018 21:43:25 +0100
+
 gpredict (2.0-4) unstable; urgency=medium
 
   * Update to v2.1-123-gc6bc520
diff --minimal -Nru gpredict-2.0/debian/patches/0125-skip-configure.patch gpredict-2.0/debian/patches/0125-skip-configure.patch
--- gpredict-2.0/debian/patches/0125-skip-configure.patch	1970-01-01 01:00:00.000000000 +0100
+++ gpredict-2.0/debian/patches/0125-skip-configure.patch	2018-01-22 21:43:22.000000000 +0100
@@ -0,0 +1,18 @@
+From: Helmut Grohne <helmut@subdivi.de>
+Subject: avoid failing configure during ./autogen.sh, let dh_auto_configure call it
+
+Index: gpredict-2.0/autogen.sh
+===================================================================
+--- gpredict-2.0.orig/autogen.sh
++++ gpredict-2.0/autogen.sh
+@@ -50,9 +50,7 @@
+ echo "- autoconf."		&& \
+   autoconf			&& \
+ echo "- automake."		&& \
+-  automake --add-missing --gnu	&& \
+-echo				&& \
+-  ./configure "$@"		&& exit 0
++  automake --add-missing --gnu	&& exit 0
+ 
+ exit 1
+ 
diff --minimal -Nru gpredict-2.0/debian/patches/0126-cross-pkg-config.patch gpredict-2.0/debian/patches/0126-cross-pkg-config.patch
--- gpredict-2.0/debian/patches/0126-cross-pkg-config.patch	1970-01-01 01:00:00.000000000 +0100
+++ gpredict-2.0/debian/patches/0126-cross-pkg-config.patch	2018-01-22 21:43:25.000000000 +0100
@@ -0,0 +1,78 @@
+Index: gpredict-2.0/configure.ac
+===================================================================
+--- gpredict-2.0.orig/configure.ac
++++ gpredict-2.0/configure.ac
+@@ -28,16 +28,21 @@
+ # check for libm
+ AC_CHECK_LIB([m], [sin],, AC_MSG_ERROR([Can not find libm. Check your libc installation]))
+ 
++PKG_PROG_PKG_CONFIG
++if test "x$PKG_CONFIG" = x; then
++    AC_MSG_ERROR(Gpredict requires pkg-config)
++fi
++
+ # check for libcurl
+-if pkg-config --atleast-version=7.19 libcurl; then
+-    CFLAGS="$CFLAGS `pkg-config --cflags libcurl`"
+-    LIBS="$LIBS `pkg-config --libs libcurl`"
++if $PKG_CONFIG --atleast-version=7.19 libcurl; then
++    CFLAGS="$CFLAGS `$PKG_CONFIG --cflags libcurl`"
++    LIBS="$LIBS `$PKG_CONFIG --libs libcurl`"
+ else
+     AC_MSG_ERROR(Gpredict requires libcurl-dev 7.19 or later)
+ fi
+ 
+ # check for glib >2.32
+-if pkg-config --atleast-version=2.32 glib-2.0; then
++if $PKG_CONFIG --atleast-version=2.32 glib-2.0; then
+     CFLAGS="$CFLAGS"
+     LIBS="$LIBS"
+ else
+@@ -45,17 +50,17 @@
+ fi
+ 
+ # check for goocanvas (depends on gtk and glib)
+-if pkg-config --atleast-version=2.0 goocanvas-2.0; then
+-    CFLAGS="$CFLAGS `pkg-config --cflags goocanvas-2.0`"
+-    LIBS="$LIBS `pkg-config --libs goocanvas-2.0`"
++if $PKG_CONFIG --atleast-version=2.0 goocanvas-2.0; then
++    CFLAGS="$CFLAGS `$PKG_CONFIG --cflags goocanvas-2.0`"
++    LIBS="$LIBS `$PKG_CONFIG --libs goocanvas-2.0`"
+ else
+     AC_MSG_ERROR(Gpredict requires libgoocanvas-2.0-dev)
+ fi
+ 
+ # check for libgps (optional)
+-if pkg-config --atleast-version=2.90 libgps; then
+-    CFLAGS="$CFLAGS `pkg-config --cflags libgps`"
+-    LIBS="$LIBS `pkg-config --libs libgps`"
++if $PKG_CONFIG --atleast-version=2.90 libgps; then
++    CFLAGS="$CFLAGS `$PKG_CONFIG --cflags libgps`"
++    LIBS="$LIBS `$PKG_CONFIG --libs libgps`"
+     havelibgps=true;
+     AC_DEFINE(HAS_LIBGPS, 1, [Define if libgps is available])
+ else
+@@ -88,15 +93,15 @@
+ AM_CONDITIONAL(UPDATE_CACHES, test x"$enable_caches" = "xyes")
+ 
+ 
+-GLIB_V=`pkg-config --modversion glib-2.0`
+-GIO_V=`pkg-config --modversion gio-2.0`
+-GTHR_V=`pkg-config --modversion gthread-2.0`
+-GDK_V=`pkg-config --modversion gdk-3.0`
+-GTK_V=`pkg-config --modversion gtk+-3.0`
+-GOOC_V=`pkg-config --modversion goocanvas-2.0`
+-CURL_V=`pkg-config --modversion libcurl`
++GLIB_V=`$PKG_CONFIG --modversion glib-2.0`
++GIO_V=`$PKG_CONFIG --modversion gio-2.0`
++GTHR_V=`$PKG_CONFIG --modversion gthread-2.0`
++GDK_V=`$PKG_CONFIG --modversion gdk-3.0`
++GTK_V=`$PKG_CONFIG --modversion gtk+-3.0`
++GOOC_V=`$PKG_CONFIG --modversion goocanvas-2.0`
++CURL_V=`$PKG_CONFIG --modversion libcurl`
+ if test "$havelibgps" = true ; then
+-   GPS_V=`pkg-config --modversion libgps`
++   GPS_V=`$PKG_CONFIG --modversion libgps`
+ fi
+  
+ 
diff --minimal -Nru gpredict-2.0/debian/patches/series gpredict-2.0/debian/patches/series
--- gpredict-2.0/debian/patches/series	2017-12-28 15:01:00.000000000 +0100
+++ gpredict-2.0/debian/patches/series	2018-01-22 21:43:25.000000000 +0100
@@ -122,3 +122,5 @@
 0122-Fix-GtkDialog-mapped-without-.-messages.patch
 0123-Update-NEWS-file.patch
 0124-Update-translation-files.patch
+0125-skip-configure.patch
+0126-cross-pkg-config.patch

--- End Message ---
--- Begin Message ---
Source: gpredict
Source-Version: 2.3-33-gca42d22-1

We believe that the bug you reported is fixed in the latest version of
gpredict, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 888043@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christoph Berg <myon@debian.org> (supplier of updated gpredict package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 31 Dec 2018 12:53:13 +0100
Source: gpredict
Binary: gpredict
Architecture: source
Version: 2.3-33-gca42d22-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Christoph Berg <myon@debian.org>
Description:
 gpredict   - Satellite tracking program
Closes: 888043
Changes:
 gpredict (2.3-33-gca42d22-1) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Christoph Berg ]
   * New upstream snapshot.
   * Create packaging repository on salsa.
   * Remove some generated files on clean.
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #888043)
     + 0125-skip-configure.patch: Only run ./configure once and let
       dh_auto_configure do it.
     + 0126-cross-pkg-config.patch: Consider $ac_tool_prefix for pkg-config.
Checksums-Sha1:
 b98c95e012e4f2eedbeefd29da5160220eb403db 2163 gpredict_2.3-33-gca42d22-1.dsc
 440ae4e5a8cb0545917fa8ea67c4c0bffdde3498 7720768 gpredict_2.3-33-gca42d22.orig.tar.gz
 ec671da55068d7c2ca0cf0092fc2b14374a34104 6140 gpredict_2.3-33-gca42d22-1.debian.tar.xz
Checksums-Sha256:
 6c2158de2675e74635e695919e181e5cb1e3396219e4eb6484e02e9e62812064 2163 gpredict_2.3-33-gca42d22-1.dsc
 e84012c7cff6fa9e7e753911cb5ad57fa70d1180924a410cd40326d174009f85 7720768 gpredict_2.3-33-gca42d22.orig.tar.gz
 5dc66c6184f9295da2353cf1a0fe40989066462a63b804c34cd27f2edb2e17b3 6140 gpredict_2.3-33-gca42d22-1.debian.tar.xz
Files:
 08884c863114e1a7e414e405f5e560b1 2163 hamradio optional gpredict_2.3-33-gca42d22-1.dsc
 dcf68881d43873744a0742d8fc29ea6b 7720768 hamradio optional gpredict_2.3-33-gca42d22.orig.tar.gz
 7032b34d98b2e5a0300e76bd95f9caf3 6140 hamradio optional gpredict_2.3-33-gca42d22-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXEj+YVf0kXlZcIfGTFprqxLSp64FAlwqBRsACgkQTFprqxLS
p65u6Q/8CjB2aX79znRjl85UouAKswbAU6q4mJYW/BJyJ/0dOqIuLvDbF8ZgKtba
3EVHIX5cEGZc/ZCMPhPazrbfGb7JNZ4gvrulKV5v1fbwls4oRQDbcG4goPnp5u8e
nt0hw7w2KBuyRSsnPsLGKAOZVv7U3Ib4bEdNAvN0fUa7QYjb/mnwwwNBu264o4k6
77qMXA3NAiqY7rGCVhrfAplURndLsEYPAMgP+QgkXkwXFZOuE4WNEbQpRLZ8jsqi
lJlKAgSgquNfVEa6JGNWZEtQa86cUbJWorfR0oxLujy6HkVHtMPunsTqHlYD3oqX
vtp93z94l/wjK1GK2O63mzpY3BpNXcWvHT7TuzjFE1bf8PZxhssQYQ7tJRSC3BX5
zzPcXkFQIBV+Y0EBZ0JG69yRotgTCgSU6XfpFALT1p+mXvmjGMhuKEn1ZN0Z4PJH
tHzRdb/qfWJOIlgMtsK5fZnMmIMCCwani1onCCIQ29ykf8xQI5CeCTe3uBni8gpB
Z4hymrh4fFFFV90zV/VPkJcB8HDCU5I2qSRzbsEh31ZtMpJpFZfuINlLgjipeouR
KPSmh8JBFwM7qCdi2VFB/knn3Ua+f4d+uqi3nZsupZGOAFRYEKHZceTBb3P9bRaw
cyWtXp3Gwbbcf20yQZD/F4NMMTgY//RHliGyNvF7GJ5jtuucgYU=
=JhL1
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: